fix: argo with fail fast does not work well with depends

AstraZeneca · May 17, 2024 · 5c6b8fc · 5c6b8fc
1 parent 672d3a3
commit 5c6b8fc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/runnable/entrypoints.py b/runnable/entrypoints.py
@@ -276,7 +276,7 @@ def execute_single_node(
     ## This step is where we save the log file
     try:
         executor.execute_node(node=node_to_execute, map_variable=map_variable_dict)
-    except Exception:  # noqa: E722
+    finally:
         log_file_name = utils.make_log_file_name(
             node=node_to_execute,
             map_variable=map_variable_dict,
@@ -287,7 +287,7 @@ def execute_single_node(
         run_context.catalog_handler.put(name=log_file_name, run_id=run_context.run_id)
         os.remove(log_file_name)
 
-    executor.send_return_code(stage="execution")
+    # executor.send_return_code(stage="execution")
 
 
 def execute_notebook(

diff --git a/runnable/extensions/executor/argo/implementation.py b/runnable/extensions/executor/argo/implementation.py
@@ -303,7 +303,7 @@ class DagTemplate(BaseModel):
     tasks: List[DagTaskTemplate] = Field(default=[], exclude=True)
     inputs: Optional[List[Parameter]] = Field(default=None, serialization_alias="inputs")
     parallelism: Optional[int] = None
-    fail_fast: bool = Field(default=True, serialization_alias="failFast")
+    fail_fast: bool = Field(default=False, serialization_alias="failFast")
 
     @field_validator("parallelism")
     @classmethod