Bug ci

.github/workflows/pr.yaml

@@ -14,6 +14,22 @@ jobs:
         with:
           python-version: 3.8
       - run: python -m pip install poetry
+      - run: |
+          # Download the binary
+          curl -sLO https://github.com/argoproj/argo-workflows/releases/download/v3.5.4/argo-linux-amd64.gz
+
+          # Unzip
+          gunzip argo-linux-amd64.gz
+
+          # Make binary executable
+          chmod +x argo-linux-amd64
+
+          # Move binary to path
+          mv ./argo-linux-amd64 /usr/local/bin/argo
+
+          # Test installation
+          argo version
+
       - run: |
           python -m poetry install
           poetry run tox

.github/workflows/release.yaml

@@ -4,6 +4,7 @@ on:
       - "magnus/**"
     branches:
       - "main"
+      - "rc"
 
 jobs:
   PRCheck:
@@ -13,10 +14,26 @@ jobs:
       - uses: actions/setup-python@v4
         with:
           python-version: 3.8
+      - run: |
+          # Download the binary
+          curl -sLO https://github.com/argoproj/argo-workflows/releases/download/v3.5.4/argo-linux-amd64.gz
+
+          # Unzip
+          gunzip argo-linux-amd64.gz
+
+          # Make binary executable
+          chmod +x argo-linux-amd64
+
+          # Move binary to path
+          mv ./argo-linux-amd64 /usr/local/bin/argo
+
+          # Test installation
+          argo version
       - run: python -m pip install poetry
       - run: |
           python -m poetry install
           poetry run tox
+
   Release:
     runs-on: ubuntu-latest
     needs: PRCheck
@@ -27,15 +44,28 @@ jobs:
       - uses: actions/setup-python@v4
         with:
           python-version: 3.8
-      - run: python -m pip install python-semantic-release==7.34.6
+      - run: python -m pip install python-semantic-release==8.0.7
       - name: Figure version
+        continue-on-error: true
         id: last_tag
         run: |
 
-          VERSION=$(semantic-release print-version --patch)
-          echo $VERSION
+          CURRENT=$(git tag --sort=-committerdate -l | head -n 1)
+          echo "current: $CURRENT"
+
+          VERSION=$(python -m semantic-release --noop --strict version --no-push --no-commit --print)
+          echo "New: $VERSION"
+
+          if [ "$CURRENT" == "$VERSION" ]; then
+            echo "version="" >> $GITHUB_OUTPUT
+            exit 1
+          fi
+
           echo "version=$VERSION" >> $GITHUB_OUTPUT
+          exit 0
+
       - name: Apply new tag
+        if: steps.last_tag.outcome == 'success'
         env:
           VERSION: ${{ steps.last_tag.outputs.version }}
         uses: actions/github-script@v6
@@ -50,6 +80,7 @@ jobs:
               sha: context.sha
             })
       - name: Publish to PyPI
+        if: steps.last_tag.outcome == 'success'
         env:
           PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }}
           LAST_TAG: ${{ steps.last_tag.outputs.version }}
@@ -60,6 +91,7 @@ jobs:
           poetry publish --build
 
       - name: "Create release"
+        if: steps.last_tag.outcome == 'success'
         env:
           RELEASE_TAG: ${{ steps.last_tag.outputs.version }}
         uses: "actions/github-script@v6"

.gitignore

@@ -141,3 +141,16 @@ cython_debug/
 
 # VSCode specific settings
 .vscode
+
+
+.run_log_store/
+
+.catalog/
+
+cov.xml
+
+.DS_Store
+
+data/
+
+example_bak/

.mypy.ini

@@ -1,6 +1,24 @@
 [mypy]
-implicit_optional = True
-ignore_missing_imports = True
+exclude = _*FF.py
+ignore_missing_imports = True
+plugins = pydantic.mypy
+show_error_codes = True
+
+follow_imports = silent
+warn_redundant_casts = True
+warn_unused_ignores = True
+#disallow_any_generics = True # This complicates it a lot
+check_untyped_defs = True
+implicit_reexport = True
+
+# for strict mypy: (this is the tricky one :-))
+#disallow_untyped_defs = True
+
+[pydantic-mypy]
+init_forbid_extra = True
+init_typed = True
+warn_required_dynamic_aliases = True
+warn_untyped_fields = True
 
 [mypy-ruamel.*]
 ignore_missing_imports = True

.pre-commit-config.yaml

@@ -27,3 +27,16 @@ repos:
         # pre-commit's default_language_version, see
         # https://pre-commit.com/#top_level-default_language_version
         language_version: python3.8
+
+  - repo: https://github.com/jorisroovers/gitlint
+    rev: v0.19.1
+    hooks:
+      - id: gitlint
+        args:
+          [
+            --contrib=CT1,
+            --ignore=title-trailing-punctuation,
+            --ignore=T3,
+            --ignore=B6,
+            --msg-filename,
+          ]