-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add pandoc theme to docs site #1277
base: main
Are you sure you want to change the base?
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
fix: paths fix paths redusx fix paths again chore: discard more chore: discard other tweak path read path
fix: delete overrides fix: break chore disable jekyll fix: apply light-dark fix styles & fonts tweaks mv assets ignore built output tweaks to theme
Hi. The page looks just incredibly stunning. Check review checklist - follow "proper conventional commit scoping", see https://www.conventionalcommits.org/en/v1.0.0/ . Your commits should start with |
Thanks @Kamilcuk, and thanks for the original script, it was really inspiring to see such a simple way to hook into github files/actions rather than using pre made abstractions. I would like to mess around with this system more, but at the moment I'm too busy. I can imagine some bash script component system to make it easier to work on individial bits of the generated site, or something like it. Also, seems like your suggested title does not pass the repo checks either, to me it looks like it's expecting a pr to target a specific already existing plugin, but I didn't have the time to look at it too much. |
Turns out the theme is not changing only in the arc browser. On safari it changes fine. @aslak01 Did you by any chance test on firefox/chrome? |
Wrong. Its docs. |
See f5f3442 |
Chrome works fine. Firefox as well. Fuck Arc, less than 1% uses it. LGTM. @mehalter U merge pookie? |
@aslak01 any reason why you added a shitton of fonts? Cant they be fetched at runtime? |
Pretty sure we can remove most of these just by doing
should be able to remove the font folder and font.css if we include that import in the theme.css |
Yep, that'd work but I prefer to self-host fonts rather than depend on google fonts where I can personally. It's the same pattern that's in use on astronvim.com. If you look in the network tab, only two fonts files are loaded, the rest are just there in case we need them in the future, since Inter is an open source font and provides the entire set of weights and styles as a set. |
@Uzaaft I can change it to fetch the font remotely if you want to make that a requirement but in my opinion "locally" hosted fonts are better. |
📑 Description
Added a nicer theme (with dark mode support) to the pandoc markdown-html conversion, tweaked colors to match astrotheme.
Credit to https://github.com/jez/pandoc-markdown-css-theme
Preview: https://aslak01.github.io/astrocommunity/
ℹ Additional Information
Moved bash script and resources to /docs/