Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use a wrapper when creating multiple translations #409

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

artemiyone
Copy link

Description:
Adding the ability to wrap multiple translations when creating new records.

Changes:
Added translations_wrapper config to allow user to set a custom wrapper name.

Purpose:
When working with DTOs, we've found it useful to be able to wrap all the translations into a specific property when creating multiple records at once.

Benefits:
Facilitates to create/convert the DTOs and use them for model creation/update.

Usage:
Developers can now set a custom wrapper for multiple creation and use it in the following way:

You may define a wrapper property when creating new translations. Set the translations_wrapper property in translatable config file:

'translations_wrapper' => 'translations',

Then just wrap multiple locales using that property:

$data = [
  'author' => 'Gummibeer',
  'translations' => [
      'en' => ['title' => 'My first post'],
      'fr' => ['title' => 'Mon premier post'],
  ],
];
$post = Post::create($data);

echo $post->translate('fr')->title; // Mon premier post

Copy link
Member

@Gummibeer Gummibeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good MR - only very little adjustments needed. 🥳

tests/TranslatableTest.php Outdated Show resolved Hide resolved
src/config/translatable.php Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
…"_translation_wrapper"

- Make subtitles H4
@artemiyone
Copy link
Author

Thanks for the feedback and sorry for the delay, busy days.

I've updated my PR and hopefully now is good to go :)

Copy link
Member

@Gummibeer Gummibeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! 😟 Toddlers aren't easy ... 🙈
Everything looking good and thanks for the changes! 🙏

@Gummibeer Gummibeer merged commit 3adf03d into Astrotomic:main Aug 26, 2024
2 checks passed
@Gummibeer
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants