fix: make fromStop and toStop input fields optional in ticket control…

… feedback form (#442) * Remove inout fields for fromStop and toStop. * Make fromStop and toStop optional.
AtB-AS · Nov 25, 2024 · 8a47261 · 8a47261
1 parent d6462c8
commit 8a47261
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 16 deletions.
diff --git a/src/page-modules/contact/ticket-control/forms/feedbackForm.tsx b/src/page-modules/contact/ticket-control/forms/feedbackForm.tsx
@@ -81,7 +81,7 @@ export const FeedbackForm = ({ state, send }: FeedbackFormProps) => {
         />
 
         <SearchableSelect
-          label={t(PageText.Contact.input.fromStop.label)}
+          label={t(PageText.Contact.input.fromStop.optionalLabel)}
           value={state.context.fromStop}
           placeholder={t(PageText.Contact.input.fromStop.optionLabel)}
           isDisabled={!state.context.line}
@@ -93,15 +93,10 @@ export const FeedbackForm = ({ state, send }: FeedbackFormProps) => {
               value: value,
             });
           }}
-          error={
-            state.context?.errorMessages['fromStop']?.[0]
-              ? t(state.context?.errorMessages['fromStop']?.[0])
-              : undefined
-          }
         />
 
         <SearchableSelect
-          label={t(PageText.Contact.input.toStop.label)}
+          label={t(PageText.Contact.input.toStop.optionalLabel)}
           value={state.context.toStop}
           placeholder={t(PageText.Contact.input.toStop.optionLabel)}
           isDisabled={!state.context.line}
@@ -113,11 +108,6 @@ export const FeedbackForm = ({ state, send }: FeedbackFormProps) => {
               value: value,
             });
           }}
-          error={
-            state.context?.errorMessages['toStop']?.[0]
-              ? t(state.context?.errorMessages['toStop']?.[0])
-              : undefined
-          }
         />
 
         <DateSelector

diff --git a/src/page-modules/contact/ticket-control/ticket-control-form-machine.ts b/src/page-modules/contact/ticket-control/ticket-control-form-machine.ts
@@ -135,8 +135,6 @@ const setInputToValidate = (context: ContextProps) => {
     SWIFT,
     transportMode,
     line,
-    fromStop,
-    toStop,
     dateOfTicketControl,
     timeOfTicketControl,
   } = context;
@@ -165,8 +163,6 @@ const setInputToValidate = (context: ContextProps) => {
       return {
         transportMode,
         line,
-        fromStop,
-        toStop,
         dateOfTicketControl,
         timeOfTicketControl,
         feedback,

diff --git a/src/translations/pages/contact.ts b/src/translations/pages/contact.ts
@@ -887,6 +887,11 @@ export const Contact = {
 
     fromStop: {
       label: _('Fra holdeplass/kai', 'From stop/harbor', 'Frå haldeplass/kai'),
+      optionalLabel: _(
+        'Velg holdeplass/kai (valgfritt)',
+        'Select stop/harbor (optinal)',
+        'Vel haldeplass/kai (valfritt)',
+      ),
       optionLabel: _(
         'Velg holdeplass/kai',
         'Select stop/harbor',
@@ -903,6 +908,11 @@ export const Contact = {
 
     toStop: {
       label: _('Til holdeplass/kai', 'To stop/harbor', 'Til haldeplass/kai'),
+      optionalLabel: _(
+        'Velg holdeplass/kai (valgfritt)',
+        'Select stop/harbor (optinal)',
+        'Vel haldeplass/kai (valfritt)',
+      ),
       optionLabel: _(
         'Velg holdeplass/kai',
         'Select stop/harbor',