fix: enable line filter for FRAM #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mikaelbr
approved these changes
Mar 4, 2024
|
Wouldn't it be easier to instead make sure that |
I think we could improve this by resetting every env variable before each build. Not sure what is the best approach to this, but I'll merge this for now and we can look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the NFK env variable
NEXT_PUBLIC_DISABLE_LINE_FILTERis used for FRAM because FRAM hasn't defined one. I've added the env variable to all organisations to prevent this from happening. We could look into "resetting" the env variables between each build as well, but this will fix the issue for now.