feat: extend planner-web to support Troms #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adriansberg
reviewed
Mar 6, 2024
| "supportEmail": "", | ||
|
|
||
| "fylkeskommune": { | ||
| "logoSrc": "/troms_fylkeskommune.svg", |
There was a problem hiding this comment.
IIRC this was a request from NFK as well, but Troms may want to have both the logo for fylkeskommune and the logo for Fylkestrafikk, like they have on their current page:
There was a problem hiding this comment.
True! Troms Fylkestrafikk is undergoing a rebranding which will result in changes to their name, logo, etc. I don't think we should put any work into this until the branding is done as this could change, but it might be something we should do later 👍
adriansberg
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the planner-web to support Troms (staging). Troms hasn't set up their Mapbox account yet, and I've used FRAMs credentials for now.
Closes https://github.com/AtB-AS/kundevendt/issues/17160