Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend widget with optional single column layout #296

Merged
merged 4 commits into from
May 31, 2024

Conversation

jonasbrunvoll
Copy link
Contributor

Closes https://github.com/AtB-AS/kundevendt/issues/18000

Background

Add the ability to choose a single column type design (enforce mobile view) for the widget.

This is a need sent in by Troms.

Illustrations

screenshots/video/figma

Skjermbilde 2024-05-30 kl  13 08 17r
Skjermbilde 2024-05-30 kl  13 08 25

Proposed solution

Include singleColumnLayout as an optional property to determine whether the widget should be shown in single column layout or not. By default set to false.

Acceptance Criteria

  • By default, single column layout is set to false.
  • Should be possible to switch to single column layout when inspecting widget, by adding copy-pasting the css class widget-module__singleColumnLayout straight into the HTML with the element class widget-module__wrapper manually.

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planner-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 7:51am

@mortennordseth
Copy link
Contributor

I think we should document the single-column option here as well 👇 The rest looks good!

image

Copy link
Contributor

@mortennordseth mortennordseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce

@jonasbrunvoll jonasbrunvoll merged commit 1ef2c6b into main May 31, 2024
5 of 6 checks passed
@jonasbrunvoll jonasbrunvoll deleted the jonas/single_column branch May 31, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants