fix: avoid opening new tab when clicking on link to contact form #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbrunvoll
requested review from
mikaelbr,
adriansberg and
mortennordseth
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Could we check if the url is external instead of making this org-specific? |
adriansberg
reviewed
Nov 29, 2024
| const urlHostname = new URL(url).hostname; | ||
| return urlHostname !== currentHostname; | ||
| } catch { | ||
| return false; |
There was a problem hiding this comment.
Is this in a try..catch in case window isn't defined?
There was a problem hiding this comment.
The try..catch is there to ensure that the function does not crash in case an invalid URL is provided.
adriansberg
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid opening a new TAB when clicking on the link in the footer to the new contact form.