Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show icon for situation or notice #57

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

adriansberg
Copy link
Contributor

@adriansberg adriansberg commented Nov 6, 2023

Show an icon when there's a situation or notice for the trip pattern. The icon is shown in the top right corner of a trip card.

Logic from the app is reused to maintain the same functionality across platforms.

Did an attempt to create a modue for situations and notices since there probably will be more coming for that, for the details page etc. Not sure if this is the way modules should be handled though.

Note: branched this off of the other PR, since the folder structure have been altered some.

image

Fixes https://github.com/AtB-AS/kundevendt/issues/14919

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planner-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 0:29am

@adriansberg adriansberg force-pushed the adriansberg/situation-or-notice branch from bfd5a55 to f8cc4fc Compare November 9, 2023 12:28
@adriansberg adriansberg marked this pull request as ready for review November 9, 2023 12:28
Copy link
Contributor

@mortennordseth mortennordseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adriansberg adriansberg merged commit 92c3b2a into main Nov 10, 2023
4 checks passed
@adriansberg adriansberg deleted the adriansberg/situation-or-notice branch November 10, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants