Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tests #268

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

New tests #268

wants to merge 3 commits into from

Conversation

rs028
Copy link
Collaborator

@rs028 rs028 commented Apr 18, 2018

I started assembling some simple models that can be solved analytically. This is to address issues #47 and #265. At the moment the tests are not executed by travis or make test.

@spco
Copy link
Collaborator

spco commented Jun 8, 2018

When this comes to merging, we'll need to redo the new test outputs, as #280 fixed a bug that affects the output.

@rs028
Copy link
Collaborator Author

rs028 commented Jun 8, 2018

We will have to decide what to do regarding the testing regime. At the moment is, I think, overly complicated/redundant. I'd like it to be simpler and more systematic. In my mind this branch was supposed to be the starting point for a new set of tests to replace the current ones (sometimes it's easier to start over from scratch, then trying to fix something but maybe it is just me). Any thoughts?

@spco
Copy link
Collaborator

spco commented Jun 8, 2018

I think some of the existing tests should certainly be dropped, though it is probably worth having a overlap period where we introduce the new ones but keep the others in place for a while. Does that sound reasonable? We can use codecov to check that our new tests cover all the code lines that the old ones do before deprecating the old ones. I agree that several of the existing tests are overkill and overlap too much.

@spco
Copy link
Collaborator

spco commented Jun 8, 2018

We also need to manufacture a few minimal tests that trigger the numerical differences between Linux and Mac, to help diagnose the cause. If we can strip out as much as possible and still see the issue then that helps.

@rs028
Copy link
Collaborator Author

rs028 commented Jun 8, 2018

Yes I agree. I think it's better to have more, but simpler/shorter tests, rather then the current system which runs complete models.
I am also wondering if it would be good to have a simple text file in travis/ which each test and what it does, so it is easier to keep track of them?

@spco
Copy link
Collaborator

spco commented Jun 20, 2018

Such a text file might be useful - not sure how to best implement that. In the meantime, can you tell me what the tests in this PR do? What are their analytic solutions?

@rs028
Copy link
Collaborator Author

rs028 commented Jun 20, 2018

I was thinking something really simple as:

test1 : two reactions mechanism to test correct use of switches A, B , C
test2 : two reaction mechanism to test contraining of chemical species
test3 : three reaction mechanism to test contraining of environment variables

I will email you about the tests in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants