Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker-compose.yaml #69

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Update docker-compose.yaml #69

merged 1 commit into from
Oct 17, 2023

Conversation

s0nagent006
Copy link
Contributor

Changed instrumentation example filename from server_uninstrumented.py to server_automatic.py as per open-telemetry/opentelemetry-python repository.

Refer to their pull request #3206 in open-telemetry/opentelemetry-python@8ebf997

@s0nagent006
Update docker-compose.yaml
17af2a3 
Changed instrumentation example filename from server_uninstrumented.py to server_automatic.py as per open-telemetry/opentelemetry-python repository.

Refer to their pull request #3206 in open-telemetry/opentelemetry-python@8ebf997
@gwenblum gwenblum added bug Something isn't working good first issue Good for newcomers labels Oct 17, 2023
@gwenblum
Copy link
Member

It seems the automatic instrumentation with the example "server_automatic.py" does not generate any trace anymore, while other examples like "server_programmatic.py" work well.

For this cookbook 103, for now we can merge with server_automatic.py and track the issue.
I also noticed some other things need update (apm collector version, replace deprecated otlp_proto_http to use otlp, ...)

@gwenblum gwenblum mentioned this pull request Oct 17, 2023
Open
4 tasks
gwenblum
gwenblum approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@gwenblum gwenblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gwenblum gwenblum merged commit 05bd665 into Aternity:main Oct 17, 2023
@gwenblum gwenblum mentioned this pull request Oct 17, 2023
Merged
gwenblum added a commit that referenced this pull request Oct 17, 2023
@gwenblum
Merge pull request #71
d3145ba 
Ref #70
- temporary patch for "the app should export traces using automatic instrumentation (ref #69 )": using server_programmatic.py instead of server_automatic.py
- updates done (otlp gRPC, apm-collector version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwenblum gwenblum gwenblum approved these changes

Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s0nagent006 @gwenblum