Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/issue 314 - Ability to add worklog during issue transition #343

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

alexsuslin
Copy link
Contributor

Description

Invoke-JiraIssueTransition now have additional parameter -TimeSpent where user can add worklog time he is working on this issue

Motivation and Context

I would like to resolve the issue and specify worklog time

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

docs/en-US/commands/Invoke-JiraIssueTransition.md Outdated Show resolved Hide resolved
@@ -41,6 +41,9 @@ function Invoke-JiraIssueTransition {
[String]
$Comment,

[String]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any particular reason why not to use [TimeSpan]?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's much common practice to use in JQL things like 10m, 8h, 3w and people get used to it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also TimeSpan is more .NET solution rather than Powershell. It should be simple to use the Module

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well...
we already have the [TimeSpan] behavior in the module (for the worklog to be precise)

[Parameter( Mandatory, ValueFromPipeline, ValueFromPipelineByPropertyName )]
[TimeSpan]
$TimeSpent,

@lipkau lipkau changed the base branch from master to develop March 18, 2019 19:16
@alexsuslin
Copy link
Contributor Author

We can discuss the behavior of SpentTime as [string] vs [TimeSpan] here, all the pros and cons

@lipkau
Copy link
Member

lipkau commented Apr 26, 2019

hey @alexsuslin .
Sorry, I forgot about this PR.

We can change the behavior, but then I would plea to change it in the other places as well.
And this would be a breaking change.

So I would suggest, to implement it as [TimeSpan] and merge it with this PR as a new minor version.
And submit a different PR where we change it to [String] and it will be merged with the next major version.
What do you think?

@lipkau
Copy link
Member

lipkau commented Jul 2, 2019

@alexsuslin ?

@lipkau
Copy link
Member

lipkau commented Oct 28, 2019

@alexsuslin : can you please update the pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants