dep-up: bump node-dlc & add tx builder validation #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3f26433 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewjablack
force-pushed
the
bump-node-dlc-0.23.1-and-add-batch-tx-builder-validation
branch
2 times, most recently
from
35a2f99
to
18dce3b
Compare
matthewjablack
force-pushed
the
bump-node-dlc-0.23.1-and-add-batch-tx-builder-validation
branch
from
18dce3b
to
3f26433
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Bump node-dlc and add batch tx builder validation in tests
What
This ensures cfd-dlc c++ batch funding tx builder has identical logic to node-dlc typescript implementation. This is verified by verifying txid from both funding txs are identical