-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto store items on container based on inscribed regex #608
base: master
Are you sure you want to change the base?
Conversation
update from main
(ready) New monsters (Attnam#349)
update from main
(ready) bug fix for show items under (Attnam#369)
(ready) Fantasy name generator (Attnam#363)
update from main
update from main
update from main
update from main
update from main
update from main
update from main
update from main
update from main
updating
udpating
update from main
update from main
update form main
…to copy from SomeFixes1234 ...)
uses pcre regex (pcre compile code unified at festring); works for normal pickup and auto-pickup; Inscribe containers with a valid regex for it to work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, if to move the code (that stores the item) becomes too complicated, just moving the message (store it in a var to display later) would suffice.
could check if it is locked, and then store only if we have a key to open it. |
That would be nice.
I would consider that bug abuse. :D Also the player might end up with items stored in chests he doesn't have a key for. |
Are we good to merge this @red-kangaroo ? |
I think there should at least be the check not to store items in locked containers. That could bite the player in the proverbial ass quite easily. :) I will try having a look at that, maybe during holidays. |
if(lRemainingVol<itToStore->GetVolume()) | ||
continue; | ||
|
||
if(itc->IsAutoStoreMatch(itToStore->GetName(DEFINITE))){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think changing this line to
if(!itc->IsLocked() && itc->IsAutoStoreMatch(itToStore->GetName(DEFINITE))){
suffices to solve #608 (comment) request
just inscribe a regex in the container
works for pickup and auto-pickup
(split from #587 using
meld
folder compare)