Introducing custom blips: as easy as a custom showname! #780

Lernos · 2022-06-05T13:34:34Z

Requires modifications from server owners for their servers to include 'custom_blips' in their "FL" packet and a new "validation monstrosity" to include a new string called blipname which must be added to the IC message args processed by the server. For backwards compatibility I suggest setting blipname as a server-side args variable to an empty string "" by default, since older clients will send nothing. In that case, the client will read the char.ini file to determine the correct blips/gender instead of looking it up in the new IC message packet.
P.S. Obviously themes need to be edited too, just add an ao2_custom_blips box somewhere near the ao2_ic_chat_name as needed.

Because otherwise it would always return only what was read from char.ini, and we want it to be able to read our custom QLineEdit too, right?

Lernos · 2022-06-05T14:45:07Z

I know, clang-tidy, I don't love you either.

stonedDiscord · 2022-06-06T17:18:12Z

../general/sfx-guitar2

in1tiate · 2022-07-07T13:21:01Z

This does not need to be part of the IC validation hell string, and as a whole blips do not need to be networked. Voting for closure.

Lernos · 2022-07-07T13:25:34Z

Why do they not need to be networked though? We allow to play custom SFX on any message, but not blips? How about the fact that canonically, Godot can imitate voices of other characters, Ted Tonate can speak either as a "ddmale" or "tonate" typing on his keyboard, Robin changes from male to female voice after her transformation, if you want to have an invisible narrator ("Anon" type of character), you'd have to make one for each blipvoice? These things are all important to players I know. Changing a character's blips to any other blips on the fly seems like a very nice customization option.

Salanto · 2022-07-14T23:01:40Z

This is double edged.
It has terrible abuse potential, but at the same time is very flexible frame_sfx is already being used to earrape everyone around them and I doubt this would fare much better.

Lernos · 2022-07-14T23:08:25Z

Well, you can't just turn frame_sfx off from my understanding. While here, a checkbox to stop displaying custom blips and fall back to the default char.ini ones could be easily coded in, similar to custom shownames. And yes, the very first portion of blip sounds coming in could be earrapey, but you could do things about it. As a player, you can turn down your blips volume or set your blips frequency in the settings to something else, then OBJECTION-interrupt the person speaking until they are dealt with by a mod. As a coder, you could additionally restrict which blips can be played by adding a function that only searches inside the blips folder instead of the whole sounds/general folder, if you so desire. Then it falls upon the custom content managing team to prevent abuse-worthy blips of entering that folder. It's immensely easier to fix this than frame_sfx, yet frame_sfx are already in the client. In any case, I'd prefer to see more flexible features added in with additional anti-abuse measures rather than them being shot down immediately even though we already allow something worse.

in1tiate · 2022-07-15T03:30:40Z

Why do they not need to be networked though? We allow to play custom SFX on any message, but not blips? How about the fact that canonically, Godot can imitate voices of other characters, Ted Tonate can speak either as a "ddmale" or "tonate" typing on his keyboard, Robin changes from male to female voice after her transformation, if you want to have an invisible narrator ("Anon" type of character), you'd have to make one for each blipvoice? These things are all important to players I know. Changing a character's blips to any other blips on the fly seems like a very nice customization option.

I hadn't considered characters with multiple blip types, which is a feature the unofficial 2.5 client had and which we currently still lack. With that in mind I'm in favor of this change but I'd prefer it to be char.ini-configurable rather than add to the Courtroom UI and deal with all the headache involved in that.

in1tiate

See above; please avoid adding clutter to the main UI

TrickyLeifa · 2022-07-27T16:52:46Z

I'd recommend linking a server pull-request that introduces the network changes so that it's easier to test the changes; and vice versa.

oldmud0

Looks fine but seems abusable - e.g. set blip name to ../music/zettaslow.

Also looking for the serverside PR for this.

Also put that profile picture away.

src/courtroom.cpp

oldmud0 · 2022-07-29T02:06:54Z

src/courtroom.cpp

@@ -177,6 +177,11 @@ Courtroom::Courtroom(AOApplication *p_ao_app) : QMainWindow()
  ui_ic_chat_name->setPlaceholderText(tr("Showname"));
  ui_ic_chat_name->setText(p_ao_app->get_default_showname());
  ui_ic_chat_name->setObjectName("ui_ic_chat_name");
+
+  ui_custom_blips = new QLineEdit(this);


Oh yeah also this definitely should be a dropdown. It's not ideal to just throw the player into the darkness and make them scroll through the files themselves.

Salanto · 2022-08-01T09:24:09Z

By the by, @Lernos. You could join the Discord to make communication a bit easier.

Crystalwarrior · 2022-08-01T15:02:17Z

Looks fine but seems abusable - e.g. set blip name to ../music/zettaslow.

Also looking for the serverside PR for this.

Also put that profile picture away.

Well servers should sanitize it in that case lmao
Also same, serverside PR would be nice

Lernos · 2022-08-02T04:00:00Z

Also put that profile picture away.

Sorry xD

By the by, @Lernos. You could join the Discord to make communication a bit easier.

Oh, I actually am. I was just dealing with stuff IRL. Not sure it would make communications that much easier, but whatever's more convenient.

Also same, serverside PR would be nice

There you go. I don't work with akashi, but I'm pretty sure it can be figured out. There should be a similar mechanism there somewhere, right?
AttorneyOnline/tsuserver3#198

Salanto · 2022-08-02T07:55:14Z

I'll handle Akashi. You might want to resolve those merge conflicts tho.

stonedDiscord · 2022-09-02T23:22:41Z

Oh yeah also this definitely should be a dropdown. It's not ideal to just throw the player into the darkness and make them scroll through the files themselves.

but which sounds should the dropdown contain?

all entries from a blips.ini file
every .opus file in base\sounds\blips
every file in base\sounds\general that starts with sfx-blip
every file from every subfolder in base\sounds\blips
all of the above

if we go with 5, what to do about the list getting too long?
my vote is on 2.

oldmud0 · 2022-09-07T02:32:22Z

I would go with 2 although it wouldn't be much additional effort to go with 4.

in1tiate · 2024-05-09T03:36:15Z

I plan on pulling the network changes from this pull request into the code I'm writing for #952 unless there are any objections. I will not be including the UI changes, as they are outside the scope of that issue.

Salanto · 2024-05-16T12:38:43Z

Stale PR + Implemented in a different PR
Thanks a bunch for the ground work, Lernos!

Lernos added 8 commits June 5, 2022 14:58

split get_blips into two functions

3f8d81a

Because otherwise it would always return only what was read from char.ini, and we want it to be able to read our custom QLineEdit too, right?

include new function, rewrite description

71ff2fc

check for custom blips support in packet

1b4e0b1

add custom blips enabled bool

0034887

increase MS_MAXIMUM, add custom blips QLineEdit

30cec4b

add BLIPNAME to chat message

ff3464a

introducing custom blips

a2af389

introducing custom blips I said

8e129ce

stonedDiscord added 2 commits June 6, 2022 20:11

Merge branch 'master' into pr/780

01efc92

Merge branch 'master' into pr/780

bf7d760

in1tiate requested changes Jul 15, 2022

View reviewed changes

TrickyLeifa added enhancement Request for functionality not present engine/viewport Issues related to viewport positioning and layering engine/audio Issues related to music and sound effect playback labels Jul 22, 2022

oldmud0 reviewed Jul 29, 2022

View reviewed changes

src/courtroom.cpp Outdated Show resolved Hide resolved

oldmud0 reviewed Jul 29, 2022

View reviewed changes

stonedDiscord added 2 commits September 3, 2022 01:13

Merge branch 'master' into feature/custom-blips

d6c6e89

unfold if

f22cb53

unfold other if

579f54a

in1tiate added 2 commits February 29, 2024 06:27

Merge branch 'master' into feature/custom-blips

b277f7a

Merge branch 'master' into feature/custom-blips

15295ec

Merge branch 'master' into feature/custom-blips

cda95d5

This was referenced May 9, 2024

Add [Options] override for blips and shownames for parity with 2.5 #953

Merged

Boilerplate for client pull request AttorneyOnline/akashi#355

Merged

Salanto closed this May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introducing custom blips: as easy as a custom showname! #780

Introducing custom blips: as easy as a custom showname! #780

Lernos commented Jun 5, 2022 •

edited

Loading

Lernos commented Jun 5, 2022

stonedDiscord commented Jun 6, 2022

in1tiate commented Jul 7, 2022

Lernos commented Jul 7, 2022

Salanto commented Jul 14, 2022

Lernos commented Jul 14, 2022

in1tiate commented Jul 15, 2022 •

edited

Loading

in1tiate left a comment

TrickyLeifa commented Jul 27, 2022

oldmud0 left a comment

oldmud0 Jul 29, 2022

Salanto commented Aug 1, 2022

Crystalwarrior commented Aug 1, 2022 •

edited

Loading

Lernos commented Aug 2, 2022

Salanto commented Aug 2, 2022

stonedDiscord commented Sep 2, 2022 •

edited

Loading

oldmud0 commented Sep 7, 2022

in1tiate commented May 9, 2024

Salanto commented May 16, 2024 •

edited

Loading

Introducing custom blips: as easy as a custom showname! #780

Introducing custom blips: as easy as a custom showname! #780

Conversation

Lernos commented Jun 5, 2022 • edited Loading

Lernos commented Jun 5, 2022

stonedDiscord commented Jun 6, 2022

in1tiate commented Jul 7, 2022

Lernos commented Jul 7, 2022

Salanto commented Jul 14, 2022

Lernos commented Jul 14, 2022

in1tiate commented Jul 15, 2022 • edited Loading

in1tiate left a comment

Choose a reason for hiding this comment

TrickyLeifa commented Jul 27, 2022

oldmud0 left a comment

Choose a reason for hiding this comment

oldmud0 Jul 29, 2022

Choose a reason for hiding this comment

Salanto commented Aug 1, 2022

Crystalwarrior commented Aug 1, 2022 • edited Loading

Lernos commented Aug 2, 2022

Salanto commented Aug 2, 2022

stonedDiscord commented Sep 2, 2022 • edited Loading

oldmud0 commented Sep 7, 2022

in1tiate commented May 9, 2024

Salanto commented May 16, 2024 • edited Loading

Lernos commented Jun 5, 2022 •

edited

Loading

in1tiate commented Jul 15, 2022 •

edited

Loading

Crystalwarrior commented Aug 1, 2022 •

edited

Loading

stonedDiscord commented Sep 2, 2022 •

edited

Loading

Salanto commented May 16, 2024 •

edited

Loading