BAPI - spacemandmm dmm reading #19118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build_bapi |
|
!build_bapi |
|
!build_bapi |
…thub.com/DreamySkrell/Aurora.3 into 2024-05-07--bapi-spacemandmm-map-parsing
|
!build_bapi |
…thub.com/DreamySkrell/Aurora.3 into 2024-05-07--bapi-spacemandmm-map-parsing
Arrow768
approved these changes
May 11, 2024
|
!build_bapi |
…thub.com/DreamySkrell/Aurora.3 into 2024-05-07--bapi-spacemandmm-map-parsing
|
!build_bapi |
…thub.com/DreamySkrell/Aurora.3 into 2024-05-07--bapi-spacemandmm-map-parsing
|
!build_bapi |
|
Building BAPI failed, see the action run log for details: https://github.com/Aurorastation/Aurora.3/actions/runs/9103102793 |
|
!build_bapi |
…thub.com/DreamySkrell/Aurora.3 into 2024-05-07--bapi-spacemandmm-map-parsing
|
!review |
Arrow768
approved these changes
May 19, 2024
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More bapi work, docs, etc.
The actual changes seen from DM side, is that all maps are parsed and checked by spacemandmm. It does not really add much safety for us, as everyone uses strongdmm anyways (which uses spacemandmm), but I will need to do that anyways in future work.
The bapi call is on every map in the maploader, so if it does not work, if it crashes or panics or whatever, we'll see it immediately (cause the maps don't load). It should work fine, though, unless the setup is wrong. I wrote more about safety and other things in readme text file in rust/bapi dir.
So, yeah. The point of this PR is to do something meaningful with bapi, and see if the whole workflow and setup and everything works correctly, before doing any further work in future PRs.