Add get_return_period and get_return_level #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `return_period` => `get_return_period` (useful variable name). `get_return_period` and `get_return_level` work for muti-dim data and for stationionary or nonstationary GEV parameters. The latter will just have an extra dimension that depends on a covariate. Also add corresponding unit tests. Add `unpack_gev_params`, which is pretty much `shape, loc, scale = params` but works if params has other dimensions or is nonstationary (returns shape, loc, scale as a function of a covariate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
return_period=>get_return_period(useful variable name).get_return_periodandget_return_levelwork for multi-dim data and for stationary or nonstationary GEV parameters. The latter will have an extra dimension that depends on a covariate. Also, add corresponding unit tests.Add
unpack_gev_params, which is pretty muchshape, loc, scale = paramsbut works if params has other dimensions or is nonstationary (returns shape, loc, scale as a function of a covariate).