Update time_utils.py and add tests #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update get_agg_dates to work with multi-dim data, remove depreciated loffset parameter from resample and add unit test. Speed up min_tsteps option in temporal_aggregation by reducing the values loaded to 2 and removing the xr.where search. This assumes only the first and last aggregation period needs to be checked and they will be consistent across all other dimensions (mainly used to ensure full time periods are aggregated when target_freq != YE-DEC). Add unit tests for min_tsteps option in temporal_aggregation. Fix mask.values = error in select_time_period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update get_agg_dates to work with multi-dim data, remove depreciated loffset parameter from resample and add unit test. Speed up min_tsteps option in temporal_aggregation by reducing the values loaded to 2 and removing the xr.where search. This assumes only the first and last aggregation period needs to be checked and they will be consistent across all other dimensions (mainly used to ensure full time periods are aggregated when target_freq != YE-DEC). Add unit tests for min_tsteps option in temporal_aggregation. Fix mask.values = error in select_time_period.