Skip to content
This repository has been archived by the owner on Apr 18, 2018. It is now read-only.

Feature/callout documentation #124

Merged
merged 1 commit into from
Jan 16, 2017

Conversation

klepas
Copy link
Contributor

@klepas klepas commented Jan 12, 2017

Description

Adds basic (missing) documentation for the existing (and three new) callouts under the Patterns section.

When merged this should fix for #119

That issue holds the bulk of the bg info.

Happy to leave this PR open for Jools to work on, or we could merge and ensure Jools sees it when he comes back — undoubtedly there’s content debt here that we will want to fix…

Additional information

Screenshot:

screen shot 2017-01-12 at 11 59 48 am

Definition of Done

  • Content/documentation reviewed by Jools or someone in the #content-design team
  • UX reviewed by Gary or someone the Design team
  • Code reviewed by one of the core developers
  • Acceptance Testing
    • HTML5 validation (CircleCI)
    • Accessibility testing & WCAG2 compliance
  • Stakeholder/PO review

@klepas klepas requested a review from joolswood January 12, 2017 01:04
@klepas klepas changed the base branch from master to develop January 12, 2017 03:49
@klepas klepas requested a review from AndrewArch January 16, 2017 00:50
@AndrewArch
Copy link

maybe we could consider a brighter green for 'success' (eg #008000) in a future release?

Copy link

@AndrewArch AndrewArch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok for now

@klepas
Copy link
Contributor Author

klepas commented Jan 16, 2017

maybe we could consider a brighter green for 'success' (eg #008000) in a future release?

@AndrewArch yea, happy to when we revisit colours in 2.x. At the moment this colour ($success-green) is setup and shared in a bunch of other places, namely forms.

@dominikwilkowski dominikwilkowski merged commit d98131d into develop Jan 16, 2017
@dominikwilkowski dominikwilkowski deleted the feature/callout-documentation branch January 16, 2017 03:10
@joolswood
Copy link
Contributor

Hey @dominikwilkowski and @klepas I don't think this is in the right place. I think what we've got are code and examples for a component called "callouts".

When we provide guidance and examples of how these components are used as part of a service to help the user then that content should go in Patterns. But I don't think we'll get to this until 2.0.

So I'd like to move this content to the Components collection and do some work on the lead-in and examples.

@klepas
Copy link
Contributor Author

klepas commented Feb 16, 2017

So I'd like to move this content to the Components collection and do some work on the lead-in and examples.

@joolswood I however want to close #119 now, and add a new issue assigned to you if you want to move this within the 1.x documentation site.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants