Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Python pre-commit hook to auto-apply suggestions #52

Closed
wants to merge 1 commit into from
Closed

Expand Python pre-commit hook to auto-apply suggestions #52

wants to merge 1 commit into from

Conversation

GuillaumeLaine
Copy link
Collaborator

@GuillaumeLaine GuillaumeLaine commented Aug 7, 2024 •
edited
Loading

The Python flake8 pre-commit hook reports style issues but does not apply fixes

Changes

  • Add Black python hook as automatic code formatter
  • Update existing hooks to latest versions

@GuillaumeLaine GuillaumeLaine changed the title Python pre commit Expan Python pre-commit hook to auto-apply suggestions Aug 7, 2024
@GuillaumeLaine GuillaumeLaine changed the base branch from main to add_compatibility_script August 7, 2024 08:28
@GuillaumeLaine GuillaumeLaine changed the title Expan Python pre-commit hook to auto-apply suggestions Expand Python pre-commit hook to auto-apply suggestions Aug 7, 2024
@GuillaumeLaine GuillaumeLaine force-pushed the add_compatibility_script branch 2 times, most recently from af9ecf6 to 8ccf51a Compare August 7, 2024 15:24
Base automatically changed from add_compatibility_script to main August 8, 2024 06:33
@GuillaumeLaine GuillaumeLaine force-pushed the python-pre-commit branch 2 times, most recently from acb2f78 to 91006f2 Compare August 9, 2024 08:07
@GuillaumeLaine GuillaumeLaine marked this pull request as ready for review August 9, 2024 08:11
bkueng
bkueng reviewed Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hesitant in the past to use black as it's very intrusive. We can give it a try though.
I generally rely on the help of the IDE to reformat too long lines.

@GuillaumeLaine
Copy link
Collaborator Author

That's a fair point, I'll rely on my IDE instead. Closing to avoid a stale PR, we can reopen later if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkueng bkueng bkueng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeLaine @bkueng