Skip to content

Commit

Permalink
Merge pull request #3 from Authress/wparad/improve-contribution-guide
Browse files Browse the repository at this point in the history
add sanitize trailing slashes to contribution guide.
  • Loading branch information
wparad authored Nov 7, 2023
2 parents 58256be + b80059f commit 06c7fea
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ podman stop $CID && podman rm $CID

### Common review items
* [ ] Inputs to Constructor are (string: authress_api_url, string: service_client_access_key)
* [ ] authress_api_url should sanitize https:// prefix and remove trailing `/`s
* [ ] Add authentication to the configuration class.
* [ ] Change configuration class name to be `AuthressSettings`
* Specify all the inputs to be consistent across languages
Expand Down

0 comments on commit 06c7fea

Please sign in to comment.