Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added note for theorist contributors to consider input parameters as … #659

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

musslick
Copy link
Collaborator

@musslick musslick commented Oct 2, 2024

Description

The contributor doc now mentiones the issues with instance attributes and sklearn estimators.

Type of change

  • docs: Documentation only changes

@musslick musslick added the documentation Improvements or additions to documentation. label Oct 2, 2024
@musslick musslick added this to the JOSS Revision milestone Oct 2, 2024
@musslick musslick self-assigned this Oct 2, 2024
docs/contribute/modules/theorist.md Outdated Show resolved Hide resolved
docs/contribute/modules/theorist.md Outdated Show resolved Hide resolved
musslick and others added 2 commits October 6, 2024 19:42
Copy link
Collaborator

@younesStrittmatter younesStrittmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@musslick musslick added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit e18b800 Oct 14, 2024
16 checks passed
@musslick musslick deleted the doc/theorist-contrib branch October 14, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants