Changche #33
Merged
Changche #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leo4realc
had a problem deploying
to
github-pages
GitHub Actions
Failure
Leo4realc
had a problem deploying
to
github-pages
GitHub Actions
Failure
lyg1597
commented
Nov 17, 2023
verse/scenario/scenario.py
Outdated
| len(self.past_runs), | ||
| self.past_runs, | ||
| ) | ||
| self.simulate = self.simulator.simulate(root, self.sensor, time_horizon, time_step, max_height, self.map, |
verse/analysis/verifier.py
Outdated
| # check height | ||
| if node.height >= max_height-1: | ||
| print("max depth reached") | ||
| break |
There was a problem hiding this comment.
Let's use continous instead of break, because we want to get everything at max_height instead of stop.
verse/analysis/simulator.py
Outdated
| @@ -836,6 +848,23 @@ def get_transition_simulate_simple( | |||
| transitions[agent_idx].append((agent_idx, dest, next_init, paths)) | |||
| return all_asserts, dict(transitions), idx | |||
| if len(satisfied_guard) > 0: | |||
| # # if config.print_level >= 1: | |||
There was a problem hiding this comment.
Let's remove this if it's not used.
verse/analysis/simulator.py
Outdated
| print("max depth reached") | ||
| continue | ||
| break |
There was a problem hiding this comment.
Use continue instead of break.
verse/analysis/simulator.py
Outdated
| # Check height | ||
| if node.height >= max_height-1: | ||
| print("max depth reached") | ||
| break |
There was a problem hiding this comment.
Use continue instead of break.
verse/analysis/simulator.py
Outdated
| @@ -231,7 +232,7 @@ def simulate_one( | |||
| new_cache, paths_to_sim = to_simulate(old_node.agent, node.agent, cached_segments) | |||
|
|
|||
| asserts, transitions, transition_idx = Simulator.get_transition_simulate( | |||
| new_cache, paths_to_sim, node, consts.lane_map, consts.sensor, consts.agent_dict | |||
| config, new_cache, paths_to_sim, node, consts.lane_map, consts.sensor, consts.agent_dict | |||
There was a problem hiding this comment.
This is a small thing. Do we need the full config or just the print level?
Leo4realc
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add different level of print to Verse.