Ensure compatibility with GCC #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various changes made to fix errors and warnings when building using GCC. These changes included qualifying base class template member types and functions, eliminating static constexpr variables in functions, and fixing typos in unused templates. Also updated readme and analysis scripts to acknowledge GCC builds.
The previous commit 7f29ca2 built under GCC but broke compiling under Visual Studio. GCC disallowed the static constexpr variable in a function, but MSVC was more strict about the order in which templates were defined. The neighborhood classes are not split into a lower level (MoveData and NeighborhoodData) and an upper level (Move and Neighborhood) establishing an ordering of template definitions that satisfies MSVC. Also updated the python scripts due to problems checking paths with backslashes.
Replacing iterators with indices just in case the iterators were the cause of some unexpected runtime patterns observed while re-running the experiment using a GCC build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised multiple source files so that the library
compiles successfully and runs reasonably
efficiently with GCC instead of only Visual Studio.
Updated the Readme to reflect these changes.