Update UE-side plugin to build against current ue5-main branch #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-generated headers with a blank line
… other non-generated headers with a blank line
…le names for FMayaLiveLinkTimelineSyncModule
…efinitions to the header file This requires making "AssetRegistry" a public dependency module, since MayaLiveLinkUtils.h is a public header.
…rom other non-generated headers with a blank line
…or window The overload of CloseWindow() that does not take a reason was deprecated as of UE 5.3.
…TimelineSyncModule.cpp
…LevelSequenceHelper.cpp
…AnimSequenceHelper.h
…TimelineSyncModule.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also enable building the UE plugin for 5.4.
Most of the changes are simply to add missing includes of header files. The last few releases of UE have been getting better about stripping out unused headers to improve compile times, so some that may have been getting included indirectly may not be any longer.
Other smaller changes of note:
FAssetEditorToolkit::CloseWindow()should be provided a reason argument (https://github.com/EpicGames/UnrealEngine/commit/31830290abdf11c3bad9dfee1e88a0cea47e562b)