Optimize Multi Resolution LBM #36

Ahdhn · 2023-03-23T23:51:55Z

Implement D3Q27
Enable NVTX on Windows
Verifying multi-resolution LBM code against Ghia et.al 1982 data and bake this into the application code.
Fix mField::forEachActiveCell such that we skip coarse cells that overlap with fine ones

github-actions · 2023-04-24T18:54:58Z

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. We ask that you sign our Contributor License Agreement before we can accept your contribution.

If you are contributing on behalf of your employer you must fill out our Corporate Contributor License Agreement which can be found here.
If you are contributing on behalf of yourself you must agree to our Individual Contributor License Agreement by reviewing this document and signing it or by replying below with a comment containing the following text:

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ @Ahdhn
❌ @Ahdhn
ahdhn seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You can retrigger this bot by commenting recheck in this Pull Request}

Ahdhn · 2023-04-24T18:56:08Z

I have read the CLA Document and I hereby sign the CLA

Ahdhn · 2023-04-24T18:59:22Z

recheck

…ResLBMOpt

…nt levels

parent testing is okay now

…o MultiResLBMOpt

Ahdhn · 2023-07-05T20:46:08Z

From Spider

Test project /home/ahmed/Neon/temp/Neon/build
      Start  1: coreUt_chrono
 1/41 Test  #1: coreUt_chrono ..........................   Passed   36.00 sec
      Start  2: coreUt_cli
 2/41 Test  #2: coreUt_cli .............................   Passed    0.00 sec
      Start  3: coreUt_digraph
 3/41 Test  #3: coreUt_digraph .........................   Passed    0.00 sec
      Start  4: coreUt_exceptions
 4/41 Test  #4: coreUt_exceptions ......................   Passed    0.00 sec
      Start  5: coreUt_io
 5/41 Test  #5: coreUt_io ..............................   Passed    4.03 sec
      Start  6: coreUt_logging
 6/41 Test  #6: coreUt_logging .........................   Passed    0.00 sec
      Start  7: coreUt_tools
 7/41 Test  #7: coreUt_tools ...........................   Passed    0.00 sec
      Start  8: coreUt_tuple3d
 8/41 Test  #8: coreUt_tuple3d .........................   Passed    0.00 sec
      Start  9: sysUt_devCpu
 9/41 Test  #9: sysUt_devCpu ...........................   Passed    0.82 sec
      Start 10: sysUt_devGpu
10/41 Test #10: sysUt_devGpu ...........................   Passed    0.92 sec
      Start 11: sysUt_devGpuNvcc
11/41 Test #11: sysUt_devGpuNvcc .......................   Passed    0.93 sec
      Start 12: sysUt_mem
12/41 Test #12: sysUt_mem ..............................   Passed    0.93 sec
      Start 13: sysUt_patterns
13/41 Test #13: sysUt_patterns .........................   Passed    1.82 sec
      Start 14: sysUt_report
14/41 Test #14: sysUt_report ...........................   Passed    0.80 sec
      Start 15: setUt_gpuSet
15/41 Test #15: setUt_gpuSet ...........................   Passed    2.15 sec
      Start 16: setUt_gpuSetNvcc
16/41 Test #16: setUt_gpuSetNvcc .......................   Passed    0.75 sec
      Start 17: setUt_memMirrorSet
17/41 Test #17: setUt_memMirrorSet .....................   Passed    1.93 sec
      Start 18: setUt_patterns
18/41 Test #18: setUt_patterns .........................   Passed    1.64 sec
      Start 19: setUt_multiDeviceObject
19/41 Test #19: setUt_multiDeviceObject ................   Passed    1.05 sec
      Start 20: setUt_containerGraph
20/41 Test #20: setUt_containerGraph ...................   Passed    4.93 sec
      Start 21: domain-globalIdx
21/41 Test #21: domain-globalIdx .......................   Passed   22.39 sec
      Start 22: domain-host-containers
22/41 Test #22: domain-host-containers .................   Passed   51.74 sec
      Start 23: domain-map
23/41 Test #23: domain-map .............................   Passed   18.80 sec
      Start 24: domain-neighbour-globalIdx
24/41 Test #24: domain-neighbour-globalIdx .............   Passed   32.74 sec
      Start 25: domain-halos
25/41 Test #25: domain-halos ...........................   Passed  152.17 sec
      Start 26: domain-stencil
26/41 Test #26: domain-stencil .........................   Passed   39.06 sec
      Start 27: domain-bGrid-tray
27/41 Test #27: domain-bGrid-tray ......................   Passed    0.72 sec
      Start 28: domainUt_sGrid
28/41 Test #28: domainUt_sGrid .........................   Passed    0.73 sec
      Start 29: domain-unit-test-eGrid
29/41 Test #29: domain-unit-test-eGrid .................   Passed    2.79 sec
      Start 30: domain-unit-test-gridInterface
30/41 Test #30: domain-unit-test-gridInterface .........   Passed   10.34 sec
      Start 31: domain-unit-test-patterns-containers
31/41 Test #31: domain-unit-test-patterns-containers ...   Passed    0.70 sec
      Start 32: domainUt_swap
32/41 Test #32: domainUt_swap ..........................   Passed   44.03 sec
      Start 33: gUt_tools
33/41 Test #33: gUt_tools ..............................   Passed    1.03 sec
      Start 34: gUt_vtk
34/41 Test #34: gUt_vtk ................................   Passed    1.36 sec
      Start 35: gUt_mGrid
35/41 Test #35: gUt_mGrid ..............................   Passed    1.27 sec
      Start 36: skeleton-map
36/41 Test #36: skeleton-map ...........................   Passed   52.40 sec
      Start 37: skeleton-stencil
37/41 Test #37: skeleton-stencil .......................   Passed    3.85 sec
      Start 38: sUt_skeletonOnStreams
38/41 Test #38: sUt_skeletonOnStreams ..................   Passed   60.51 sec
      Start 39: sUt_userInterface
39/41 Test #39: sUt_userInterface ......................   Passed  103.64 sec
      Start 40: sUt_multiRes
40/41 Test #40: sUt_multiRes ...........................   Passed    5.22 sec
      Start 41: app-lbmMultiRes
41/41 Test #41: app-lbmMultiRes ........................   Passed    1.41 sec

100% tests passed, 0 tests failed out of 41

Total Test time (real) = 665.65 sec
******************************
Test final report location: /home/ahmed/Neon/temp/Neon/build/CTestNeonUnixReport.log
******************************

Ahdhn · 2023-07-05T20:46:36Z

From Windows:

Test project E:/Github/Neon/temp/Neon/build
      Start  1: coreUt_chrono
 1/41 Test  #1: coreUt_chrono ..........................   Passed   36.33 sec
      Start  2: coreUt_cli
 2/41 Test  #2: coreUt_cli .............................   Passed    0.21 sec
      Start  3: coreUt_digraph
 3/41 Test  #3: coreUt_digraph .........................   Passed    0.35 sec
      Start  4: coreUt_exceptions
 4/41 Test  #4: coreUt_exceptions ......................   Passed    0.21 sec
      Start  5: coreUt_io
 5/41 Test  #5: coreUt_io ..............................   Passed   12.62 sec
      Start  6: coreUt_logging
 6/41 Test  #6: coreUt_logging .........................   Passed    0.23 sec
      Start  7: coreUt_tools
 7/41 Test  #7: coreUt_tools ...........................   Passed    0.32 sec
      Start  8: coreUt_tuple3d
 8/41 Test  #8: coreUt_tuple3d .........................   Passed    0.20 sec
      Start  9: sysUt_devCpu
 9/41 Test  #9: sysUt_devCpu ...........................   Passed    0.37 sec
      Start 10: sysUt_devGpu
10/41 Test #10: sysUt_devGpu ...........................   Passed    0.68 sec
      Start 11: sysUt_devGpuNvcc
11/41 Test #11: sysUt_devGpuNvcc .......................   Passed    0.52 sec
      Start 12: sysUt_mem
12/41 Test #12: sysUt_mem ..............................   Passed   17.72 sec
      Start 13: sysUt_patterns
13/41 Test #13: sysUt_patterns .........................   Passed    1.93 sec
      Start 14: sysUt_report
14/41 Test #14: sysUt_report ...........................   Passed    0.34 sec
      Start 15: setUt_gpuSet
15/41 Test #15: setUt_gpuSet ...........................   Passed    0.50 sec
      Start 16: setUt_gpuSetNvcc
16/41 Test #16: setUt_gpuSetNvcc .......................   Passed    0.30 sec
      Start 17: setUt_memMirrorSet
17/41 Test #17: setUt_memMirrorSet .....................   Passed    0.48 sec
      Start 18: setUt_patterns
18/41 Test #18: setUt_patterns .........................   Passed    2.10 sec
      Start 19: setUt_multiDeviceObject
19/41 Test #19: setUt_multiDeviceObject ................   Passed    0.51 sec
      Start 20: setUt_containerGraph
20/41 Test #20: setUt_containerGraph ...................   Passed    3.99 sec
      Start 21: domain-globalIdx
21/41 Test #21: domain-globalIdx .......................   Passed    3.26 sec
      Start 22: domain-host-containers
22/41 Test #22: domain-host-containers .................   Passed    9.97 sec
      Start 23: domain-map
23/41 Test #23: domain-map .............................   Passed    2.20 sec
      Start 24: domain-neighbour-globalIdx
24/41 Test #24: domain-neighbour-globalIdx .............   Passed    5.04 sec
      Start 25: domain-halos
25/41 Test #25: domain-halos ...........................   Passed   11.56 sec
      Start 26: domain-stencil
26/41 Test #26: domain-stencil .........................   Passed    5.10 sec
      Start 27: domain-bGrid-tray
27/41 Test #27: domain-bGrid-tray ......................   Passed    0.30 sec
      Start 28: domainUt_sGrid
28/41 Test #28: domainUt_sGrid .........................   Passed    0.41 sec
      Start 29: domain-unit-test-eGrid
29/41 Test #29: domain-unit-test-eGrid .................   Passed    0.61 sec
      Start 30: domain-unit-test-gridInterface
30/41 Test #30: domain-unit-test-gridInterface .........   Passed    1.92 sec
      Start 31: domain-unit-test-patterns-containers
31/41 Test #31: domain-unit-test-patterns-containers ...   Passed    0.48 sec
      Start 32: domainUt_swap
32/41 Test #32: domainUt_swap ..........................   Passed   10.40 sec
      Start 33: gUt_tools
33/41 Test #33: gUt_tools ..............................   Passed    0.41 sec
      Start 34: gUt_vtk
34/41 Test #34: gUt_vtk ................................   Passed    0.70 sec
      Start 35: gUt_mGrid
35/41 Test #35: gUt_mGrid ..............................   Passed    0.58 sec
      Start 36: skeleton-map
36/41 Test #36: skeleton-map ...........................   Passed    3.25 sec
      Start 37: skeleton-stencil
37/41 Test #37: skeleton-stencil .......................   Passed    1.22 sec
      Start 38: sUt_skeletonOnStreams
38/41 Test #38: sUt_skeletonOnStreams ..................   Passed   14.49 sec
      Start 39: sUt_userInterface
39/41 Test #39: sUt_userInterface ......................   Passed  116.54 sec
      Start 40: sUt_multiRes
40/41 Test #40: sUt_multiRes ...........................   Passed    9.38 sec
      Start 41: app-lbmMultiRes
41/41 Test #41: app-lbmMultiRes ........................   Passed    1.52 sec

100% tests passed, 0 tests failed out of 41

Total Test time (real) = 279.43 sec
"******************************"
"Test final report location: E:\Github\Neon\temp\Neon\build\CTestNeonWindowsReport.log"
"******************************"

massimim

Sounds great!

Ahdhn and others added 16 commits March 20, 2023 14:46

validation code

60106bb

update validation data and plots using Re=100

2f110bd

use large grid size

181b453

lower Re

186c942

Filter out overlapping cells in forEachActiveCell and update plots

7c6a5cb

update uniform plots

bf0e583

organize plotting code

cdbc7e0

Allow Q27

985fd1d

enable nvtx on windows

0e77ad5

KBC

8e8784a

fix compilation

9f52727

Fix KBC

69e7ce4

use KGB

72417ec

fix

c8d9d5b

reorg multi-res LBM app

429faf1

fix cudaErrorInvalidDeviceFunction error

fcd3d10

Autodesk deleted a comment from github-actions bot Apr 24, 2023

Ahdhn added 10 commits April 24, 2023 15:00

Update lbmMultiRes.cu

64d09a7

Hardwired KBG

c8beebf

debugging collideBGKUnrolled

71c1434

WIP initiate Store from the fine level

b0d8b0a

storeFine seems to work now

6b3c005

fix indexing in storeFine

db1dfee

minor tweak to in storeCoarse

6126b3b

averaging for storeFine

bc9a4d1

minor fix

413bc3b

verify simulation in code

f5ab228

Ahdhn added 18 commits June 6, 2023 13:43

re-enable mGrid

2921f79

WIP fix mgrid

c4616e4

Merge branch 'develop' of https://github.com/Autodesk/Neon into Multi…

5158071

…ResLBMOpt

done with integrating mGrid and mField with the refactored bGrid

f8dea2e

warnings

2116890

isActive in bPartition

9e4802a

minor fixes in mGird and mField

82a27ee

runtime depth in mGridDescriptor

2f16698

simplify (and fix) filtering out overlapping between grids of differe…

19cb395

…nt levels

MultiResSingleMap is working

c13b48d

MultiResStencil is working

9b681e0

fix mPartition

c1326a3

parent testing is okay now

Fix child info

f51c845

multi-res skeleton and demo

686d130

fix compilation issues with lbmMultiRes

857992a

fix hasChildren

a9509e0

another one

64b1693

warnings

9e90850

Ahdhn marked this pull request as ready for review July 5, 2023 16:01

Ahdhn added 3 commits July 5, 2023 14:28

minor fix to eGrid

83259f9

Merge branch 'MultiResLBMOpt' of https://github.com/Autodesk/Neon int…

95e379d

…o MultiResLBMOpt

fix Partition1D

f8ed659

Ahdhn requested a review from massimim July 5, 2023 20:47

Ahdhn added 2 commits July 6, 2023 16:00

Fix childID

6efd74f

Fix uncleOffset

6c35453

massimim approved these changes Jul 6, 2023

View reviewed changes

Ahdhn merged commit 6c35453 into develop Jul 6, 2023
12 of 13 checks passed

github-actions bot locked and limited conversation to collaborators Jul 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize Multi Resolution LBM #36

Optimize Multi Resolution LBM #36

Ahdhn commented Mar 23, 2023 •

edited

Loading

github-actions bot commented Apr 24, 2023

Ahdhn commented Apr 24, 2023

Ahdhn commented Apr 24, 2023

Ahdhn commented Jul 5, 2023 •

edited

Loading

Ahdhn commented Jul 5, 2023 •

edited

Loading

massimim left a comment

Optimize Multi Resolution LBM #36

Optimize Multi Resolution LBM #36

Conversation

Ahdhn commented Mar 23, 2023 • edited Loading

github-actions bot commented Apr 24, 2023

Ahdhn commented Apr 24, 2023

Ahdhn commented Apr 24, 2023

Ahdhn commented Jul 5, 2023 • edited Loading

Ahdhn commented Jul 5, 2023 • edited Loading

massimim left a comment

Choose a reason for hiding this comment

Ahdhn commented Mar 23, 2023 •

edited

Loading

Ahdhn commented Jul 5, 2023 •

edited

Loading

Ahdhn commented Jul 5, 2023 •

edited

Loading