-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed selection highlighting removed on Maya object by isolate select. #198
Fixed selection highlighting removed on Maya object by isolate select. #198
Conversation
@@ -478,7 +478,10 @@ class MayaPathMapper : public Fvp::PathMapper | |||
|
|||
Fvp::PrimSelections | |||
UfePathToPrimSelections(const Ufe::Path& appPath) const override { | |||
return _piSi.UfePathToPrimSelectionsLit(appPath); | |||
auto litPaths = _piSi.UfePathToPrimSelectionsLit(appPath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awkwardly, when selected, Maya objects have geometry under two Hydra prim hierarchies, with selection highlighting geometry (poly wire) rooted under /MayaHydraViewportRenderer/rprims
, and the real mesh geometry under /MayaHydraViewportRenderer/rprims/Lighted
. Both must be considered "selected" for isolate select to preserve them in the scene, otherwise the unlit selection highlighting geometry will be hidden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall we have a tech debt to remove /Lighted for lit prims, something worth a look later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the fix, the test fails. With the fix, the test passes.
cmds.mayaHydraCppTest('/MayaHydraViewportRenderer/rprims/pTorus1', | ||
f='TestPrimPath.isVisible'); | ||
cmds.mayaHydraCppTest('/MayaHydraViewportRenderer/rprims/Lighted/pTorus1', | ||
f='TestPrimPath.isVisible'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both the selection highlighting and the real geometry are visible under isolate select.
f='TestPrimPath.isVisible'); | ||
cmds.mayaHydraCppTest('/MayaHydraViewportRenderer/rprims/Lighted/pTorus1', | ||
f='TestPrimPath.isVisible'); | ||
cmds.mayaHydraCppTest('/MayaHydraViewportRenderer/rprims/Lighted/group1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Geometry that is not isolate selected is not visible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a testing utility to receive paths directly as Hydra prim paths, not application UFE paths.
No description provided.