Refactored test case plugin loading and unloading. #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Nov 19, 2024
|
|
||
| def createScene(self): | ||
| self._locator = cmds.createNode('MhFlowViewportAPILocator') | ||
| cmds.setAttr(self._locator + '.numCubesX', 3) | ||
| cmds.setAttr(self._locator + '.numCubesY', 3) | ||
| cmds.setAttr(self._locator + '.numCubesZ', 3) | ||
|
|
||
| @classmethod |
There was a problem hiding this comment.
This is the duplication, brought back to the base class.
| @@ -94,6 +97,12 @@ def setUp(self): | |||
|
|
|||
| @classmethod | |||
| def tearDownClass(cls): | |||
There was a problem hiding this comment.
Base class now unloads plugins that were loaded specifically for the test.
test/testUtils/mtohUtils.py
Outdated
| # Clean out the scene to allow all plugins to unload cleanly. | ||
| cmds.file(new=True, force=True) | ||
| for p in reversed(cls._pluginsToUnload): | ||
| if p != 'mayaHydraFlowViewportAPILocator': |
There was a problem hiding this comment.
Unloading this plugin crashes, entered as HYDRA-1304.
lilike-adsk
approved these changes
Nov 19, 2024
ppt-adsk
added
the
ready-for-merge
lilike-adsk
deleted the
tremblp/HYDRA-1083/test_case_plugin_load_refactoring
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was duplication of infrastructure for loading plugins needed for a test, and unloading them afterwards. This has been removed, and the union of the support was kept, including the
_requiredPluginsPython class variable that is presented in the Markdown documentation.