Create shader attributes if its not created when query

Autodesk · Jul 19, 2023 · dd5d37c · dd5d37c
1 parent 93cadb1
commit dd5d37c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/lib/mayaUsd/ufe/UsdLight.cpp b/lib/mayaUsd/ufe/UsdLight.cpp
@@ -175,6 +175,11 @@ bool getLightShadowEnable(const UsdPrim& prim)
     const UsdLuxShadowAPI      shadowAPI(prim);
     const PXR_NS::UsdAttribute lightAttribute = shadowAPI.GetShadowEnableAttr();
 
+    if (!lightAttribute) {
+        // If the shadow enable attribute is not created yet, create one here
+        shadowAPI.CreateShadowEnableAttr(VtValue(true));
+    }
+
     bool val = false;
     lightAttribute.Get(&val);
     return val;
@@ -187,9 +192,6 @@ void setLightShadowEnable(const UsdPrim& prim, bool attrVal)
 
     if (lightAttribute) {
         lightAttribute.Set(attrVal);
-    } else {
-        const PXR_NS::UsdAttribute shadowAttribute = shadowAPI.CreateShadowEnableAttr();
-        shadowAttribute.Set(attrVal);
     }
 }
 
@@ -210,6 +212,11 @@ Ufe::Color3f getLightShadowColor(const UsdPrim& prim)
     const UsdLuxShadowAPI      shadowAPI(prim);
     const PXR_NS::UsdAttribute lightAttribute = shadowAPI.GetShadowColorAttr();
 
+    if (!lightAttribute) {
+        // If the shadow color attribute is not created yet, create one here
+        shadowAPI.CreateShadowColorAttr();
+    }
+
     GfVec3f val(0.f, 0.f, 0.f);
     lightAttribute.Get(&val);
     return Ufe::Color3f(val[0], val[1], val[2]);

diff --git a/lib/mayaUsd/ufe/UsdLightHandler.cpp b/lib/mayaUsd/ufe/UsdLightHandler.cpp
@@ -46,10 +46,7 @@ Ufe::Light::Ptr UsdLightHandler::light(const Ufe::SceneItem::Ptr& item) const
     if (!lightSchema)
         return nullptr;
 
-    UsdLight::Ptr usdLight = UsdLight::create(usdItem);
-    usdLight->shadowEnable(true);
-
-    return usdLight;
+    return UsdLight::create(usdItem);
 }
 
 } // namespace ufe