EMSUSD-101 Override primWriter #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelliu-adsk
force-pushed
the
samuelliu-adsk/EMSUSD-101/override-primwriter
branch
from
3a6abe8
to
fa18274
Compare
samuelliu-adsk
added
adsk
calligrapheric
approved these changes
Jul 4, 2023
AramAzhari-adsk
previously approved these changes
Jul 5, 2023
seando-adsk
previously approved these changes
Jul 11, 2023
samuelliu-adsk
dismissed stale reviews from seando-adsk and AramAzhari-adsk
via
a43f3e8
samuelliu-adsk
requested review from
calligrapheric,
AramAzhari-adsk and
pierrebai-adsk
and removed request for
calligrapheric and
AramAzhari-adsk
| int _index; | ||
| }; | ||
|
|
||
| // typedef std::map<std::string, UsdMayaPrimWriterRegistry::WriterFactoryFn> _Registry; |
There was a problem hiding this comment.
I think this typedef in comment was left-over and probably should be removed.
| { | ||
| TfRegistryManager::GetInstance().SubscribeTo<UsdMayaPrimWriterRegistry>(); | ||
|
|
||
| // unfortunately, usdTypeName is diff from the tfTypeName which we use to | ||
| // register. do the conversion here. | ||
| WriterFactoryFn ret = nullptr; |
There was a problem hiding this comment.
IDK what that erased comment about usdTypeName vs tfTypeName was about... I guess it is now irrelevant?
pierrebai-adsk
requested changes
Jul 25, 2023
pierrebai-adsk
approved these changes
Jul 26, 2023
samuelliu-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CanExportfunction to primWriter for overriding default primWriterPokefunction for cases when only wants to check for plugin register but not really find a primWriter