LOOKDEVX-1592 - Clean up references, targets, and connections on delete #3194
Conversation
Similar to what is done on Rename, we traverse the scene and clean up any reference, target, or connection that will become invalid once the prim is removed.
JGamache-autodesk
added
ufe-usd
| const SdfReferencesProxy& referencesList, | ||
| SdfListOpType op) | ||
| { | ||
| // set the listProxy based on the SdfListOpType |
There was a problem hiding this comment.
In this file, please always compare with the function just above the new one to see the difference between cleaning up and renaming.
| prepend apiSchemas = ["MaterialBindingAPI"] | ||
| ) | ||
| { | ||
| rel material:binding = </mtl/BrownMat> |
There was a problem hiding this comment.
This material will be propagated to all children.
| prepend apiSchemas = ["MaterialBindingAPI"] | ||
| ) | ||
| { | ||
| rel material:binding = </mtlFoliage/GreenMat> |
There was a problem hiding this comment.
This material wins over the parent material.
| SdfReferencesProxy referencesList = primSpec->GetReferenceList(); | ||
|
|
||
| // update append/prepend lists individually | ||
| removeInternalReferencePath(deletedPrim, referencesList, SdfListOpTypeAppended); |
There was a problem hiding this comment.
Even in the previously-existing version for rename, IDK why we don't treat the SdfListOpTypeOrdered, SdfListOpTypeAdded, SdfListOpTypeExplicit and SdfListOpTypeDeleted. MayaUSd might not author those, but we can edit USD file that may contain them.
| # Ref2 has an "external" reference, but to this file. It will not be | ||
| # cleaned up because external, baut maybe it should have since the | ||
| # referenced file happens to be the root layer? | ||
| self.assertTrue(stage.GetPrimAtPath('/TreeBase/leaf_ref_2').HasAuthoredReferences()) |
There was a problem hiding this comment.
Indeed, might be good to file a story to improve this, along with my comments about other list ops.
There was a problem hiding this comment.
Also small typo baut -> but, no need to respin teh PR just for that in a unit test though
|
Thanks Pierre, I have opened EMSUSD-251 to track improvements. |
JGamache-autodesk
added
the
ready-for-merge
seando-adsk
deleted the
gamaj/LOOKDEVX-1592/clean_up_relationships_on_delete
branch
Similar to what is done on Rename, we traverse the scene and clean up any reference, target, or connection that will become invalid once the prim is removed.