EMSUSD-249 Refactors relative path dialog options to be more clear #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -142,7 +139,6 @@ def uiInit(cls, parentLayout, canBeRelative, relativeToWhat): | |||
| showPreviewFields = cmds.file(q=True, exists=True) | |||
There was a problem hiding this comment.
I think the two-lines conditional above can be removed, and the showPreviewFields variable above it.
There was a problem hiding this comment.
Wouldn't we still want to show the unresolved field? (Now called Path Preview)
There was a problem hiding this comment.
Oh sorry, the variable is also usedfor the other field, NVM, I thought it was only for the resolved path.
pierrebai-adsk
requested changes
Jul 5, 2023
samuelliu-adsk
previously approved these changes
Jul 5, 2023
AramAzhari-adsk
added
the
ready-for-merge
seando-adsk
reviewed
Jul 5, 2023
| widgetColumn = cmds.columnLayout() | ||
| cmds.checkBox(cls.kMakePathRelativeCheckBox, label=kMakePathRelativeStr, ann=kMakePathRelativeAnnStr) | ||
|
|
||
| cmds.checkBox(cls.kMakePathRelativeCheckBox, edit=True, changeCommand=cls.onMakePathRelativeChanged) | ||
| cmds.textFieldGrp(cls.kUnresolvedPathTextField, label=kUnresolvedPathStr, ann=kUnresolvedPathAnnStr, editable=False) | ||
| cmds.textFieldGrp(cls.kResolvedPathTextField, label=kResolvedPathStr, ann=kResolvedPathAnnStr , editable=False) |
There was a problem hiding this comment.
I think line 39 should also be removed (where this string is set).
AramAzhari-adsk
dismissed stale reviews from samuelliu-adsk and pierrebai-adsk
via
5e06635
AramAzhari-adsk
removed
the
ready-for-merge
seando-adsk
approved these changes
Jul 5, 2023
seando-adsk
deleted the
azharia/EMSUSD-249/RefactorRelativePathDialogOptionsToBeMoreClear
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMSUSD-249 Refactors relative path dialog options to be more clear