-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAYA-129260 - MayaUsd: make building with Ufe mandatory and remove v1 support #3217
Changes from 7 commits
6e409b6
f3c633b
869f652
a04265d
30de1c1
03c78ae
e9eb1f9
b2aefa2
e5bedb1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -227,8 +227,8 @@ Headers should be included in the following order, with each section separated b | |
|
||
#include <string> | ||
|
||
#if defined(WANT_UFE_BUILD) | ||
#include <ufe/ufe.h> | ||
#ifdef UFE_V2_FEATURES_AVAILABLE | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we still need the UFE_V2_FEATURES_AVAILABLE flag if we can only build with UFE V2 available? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah right, this flag will always be available in ufe.h, but I should have used the V3 one here. |
||
#include <ufe/types.h> | ||
#endif | ||
``` | ||
|
||
|
@@ -242,7 +242,7 @@ Headers should be included in the following order, with each section separated b | |
* `MAYA_APP_VERSION` is a simple year number, so it is not allowed in C++ code. However it is set as a CMake variable and allowed in cmake files. | ||
|
||
**UFE** | ||
* `WANT_UFE_BUILD` equals 1 if UFE is found and it should be used for conditional compilation on codes depending on UFE. | ||
* Each version of Ufe contains a features available define (in ufe.h) such as `UFE_V4_FEATURES_AVAILABLE` that can be used for conditional compilation on code depending on Ufe Version. | ||
|
||
**USD** | ||
* `PXR_VERSION` is the macro to test USD version (`PXR_MAJOR_VERSION` * 10000 + `PXR_MINOR_VERSION` * 100 + `PXR_PATCH_VERSION`) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ufe is not mandatory and we must find at least v2 (for Maya 2022).