EMSUSD-252 relative payload preview #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the preview of the relative path for payloads, references and assets (textures). - Rename the field _parentLayerPath to _relativeToDir since it is not always a parent layer folder. - Add explicit flag to use the scene file path as the relative base. - Otherwise, the scene file would be used when the layer is not yet saved, which would be incorrect and misleading. - Set _relativeToDir in the usdFileRelativeToEditTargetLayer uiInit function. - Failing to do that made the base class use the scene file folder instead, which was incorrect.
pierrebai-adsk
added
bug
|
The only PF failure is one of the known random export failures when renaming temp files. |
AramAzhari-adsk
approved these changes
Jul 14, 2023
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the preview of the relative path for payloads, references and assets (textures).