Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pxr header #3230

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Include pxr header #3230

merged 1 commit into from
Jul 14, 2023

Conversation

dj-mcg
Copy link
Collaborator

@dj-mcg dj-mcg commented Jul 14, 2023

This was getting picked up implicitly via the include in pxr/base/arch/defines.h but that is getting removed in usd 23.08

This was getting picked up implicitly via the include in
pxr/base/arch/defines.h but that is getting removed in usd 23.08
@dj-mcg
Copy link
Collaborator Author

dj-mcg commented Jul 14, 2023

I'm a little confused by the preflight failure. It looks like testVP2RenderDelegateDisplayLayers is failing in its image compare but I'm not sure how my change would cause that

@seando-adsk seando-adsk added build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge labels Jul 14, 2023
@seando-adsk
Copy link
Collaborator

@dj-mcg That test has been known to randomly fail. I'll merge this one.

@seando-adsk seando-adsk merged commit 81704ad into Autodesk:dev Jul 14, 2023
11 of 12 checks passed
@dj-mcg dj-mcg deleted the pr/Include_Pxr_Header branch July 17, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants