EMSUSD-77 - Newly created USD Lights can't cast shadows #3233
Conversation
lib/mayaUsd/ufe/UsdLight.cpp
Outdated
| @@ -175,6 +175,11 @@ bool getLightShadowEnable(const UsdPrim& prim) | |||
| const UsdLuxShadowAPI shadowAPI(prim); | |||
| const PXR_NS::UsdAttribute lightAttribute = shadowAPI.GetShadowEnableAttr(); | |||
|
|
|||
| if (!lightAttribute) { | |||
| // If the shadow enable attribute is not created yet, create one here | |||
| shadowAPI.CreateShadowEnableAttr(VtValue(true)); | |||
There was a problem hiding this comment.
Should we default to true here? Does HdStorm render shadows when the attribute doesn't exist?
There was a problem hiding this comment.
Also, you don't seem to set lightAttribute inside this if, so I'm not sure how the further code works in this case
There was a problem hiding this comment.
So for the default value, I set it as true because I think its natural for a light to cast shadows? I see that's the behavior in Maya (if user created a maya light and duplicated as USD light, it casts shadows as default) so I assume we should do the same for USD light as well... Just dont want the user to be confused.
There was a problem hiding this comment.
Ok, sounds good. So just make sure to set the lightAttribute, and we'll be good to go.
There was a problem hiding this comment.
And please do it here and below for the shadow color attribute
samuelliu-adsk
added
the
ready-for-merge
seando-adsk
added
ufe-usd
seando-adsk
deleted the
samuelliu-adsk/EMSUSD-77/USD_light_cant_cast_shadow
branch
Create USD light from USD will cause the bug. The root cause is that those shadow attributes are never added to the USD created lights. So create Shadow attributes at first query if the attribute is not created