HYDRA-496: Fix for crash on new scene with a USD Stage inside the Maya scene #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roopavr-adsk
added
adsk
lilike-adsk
approved these changes
Sep 13, 2023
seando-adsk
approved these changes
Sep 13, 2023
seando-adsk
added
core
|
@roopavr-adsk You need to have a successful preflight run before marking as ready-for-merge. In order to run the preflight you need to assign the ecp-maya-devops-adsk user |
roopavr-adsk
added
adsk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maya crashes when the MayaUsdProxyShapeSceneIndex tries to access MayaUsdProxyShape which is no longer valid. This event happens for example in the case seen here in the reivew code to set time on the USD Stage. In this situation a Maya callback registered for "timechanged" event was also triggered on "New Scene" event but the USD and Hydra resources were deleted by then on which the callback tried to set the time and hence the crash.
The fix involves adding new API to MayaUsdProxyShapeStageExtraData which is a container of sorts for MayaUsdProxyShapeBase. The API allows to check if the proxy shape requested is valid.