Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC 2022 compiler fixes + minor correction for older Hydra APIs #3872

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

boberfly
Copy link
Contributor

@boberfly boberfly commented Aug 1, 2024

Hi, I just have some small fixes when compiling with MSVC 2022 and targetting an older Hydra API (USD 23.02).

First commit has the compiler fixes (changing operator notation and to && and not to !) and the second commit has the comma fix for old hydra APIs.

I used these fixes for release/v0.29.0 but I thought I'd target the dev branch for upstreaming.

Cheers

seando-adsk
seando-adsk previously approved these changes Aug 1, 2024
@seando-adsk seando-adsk added the build Related to building maya-usd repository label Aug 1, 2024
@seando-adsk
Copy link
Collaborator

@boberfly Thanks for the pull-request. Just so you are aware of our process. Any PRs from external clients are first assigned to an internal Autodesk dev for code review. Once approved, we will launch a preflight build (by assigning the PR to the creator - something an external user is not allowed to do - for security reasons). If the preflight fails (build or test, we will post the results in a comment for you to fix, and re-run preflight, if needed). Note: for security reasons we also don't post the full build logs, so the details link next to a preflight doesn't contain any log info. Once a successful preflight run is done, we add the label "ready for merge" and then one of our admins (usually me) will merge the PR.

FYI, I started the preflight but it failed the clang-format step. You can click the details next to clang-format to see the results. Please see our codingGuidelines.md for more info.

Sean

@seando-adsk seando-adsk assigned boberfly and unassigned boberfly Sep 17, 2024
@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Sep 18, 2024
@seando-adsk seando-adsk merged commit a17e33d into Autodesk:dev Sep 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants