EMSUSD-1619 fix removal on multiple layers #3915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When removing multiple layers the removal must not be delayed. This is due to the low-level implementation of layer removal: it uses the parent layer and the index of the sub-layer to be removed instead of its name. Wehn commands are delayed, the index would become incorrect. By not delaying command, the index is properly calculated.
pierrebai-adsk
added
bug
AramAzhari-adsk
approved these changes
Sep 13, 2024
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing multiple layers the removal must not be delayed. This is due to the low-level implementation of layer removal: it uses the parent layer and the index of the sub-layer to be removed instead of its name. When commands are delayed, the index would become incorrect. By not delaying command, the index is properly calculated.