EMSUSD-948 scale export to USD according to units #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UI for export units: - Add a new -unit (-unt) flag to the export command. - Change the existing -exportDistanceUnit default to be false, to avoid clashing witth the new -unit option. - Document it. - Add corresponding unit tokens and value in the job arguments. - Expose it to Python. - Add UI to control the flag in the export dialog. Scale during export: - Use the same method as for up-axis: modify root node before export and undo after export. - That is group all root nodes and scale them, export to USD, then ungroup. - Re-use the same group as for up-axis and same undo, for efficiency. - Correctly handle the difference between Maya UI units and Maya internal data units. Add unit tests.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-948/export-usd-units
branch
from
c3f3155
to
0cd3703
Compare
pierrebai-adsk
commented
Sep 30, 2024
| @@ -1111,7 +1127,7 @@ const VtDictionary& UsdMayaJobExportArgs::GetDefaultDictionary() | |||
| d[UsdMayaJobExportArgsTokens->exportAssignedMaterials] = true; | |||
| d[UsdMayaJobExportArgsTokens->legacyMaterialScope] = false; | |||
| d[UsdMayaJobExportArgsTokens->exportDisplayColor] = false; | |||
| d[UsdMayaJobExportArgsTokens->exportDistanceUnit] = true; | |||
| d[UsdMayaJobExportArgsTokens->exportDistanceUnit] = false; | |||
There was a problem hiding this comment.
Since the default for the new unit option is "Maya Prefs", we are better off with exportDistanceUnit being off by deault, otherwise it would overwrite what the unit option would try to do.
barbalt
reviewed
Oct 1, 2024
| _autoAxisAndUnitsChanger = std::make_unique<AutoUpAxisAndUnitsChanger>( | ||
| mJobCtx.mStage, mJobCtx.mArgs.upAxis, mJobCtx.mArgs.unit); | ||
|
|
||
| // TODO: handle mJobCtx.mArgs.unit |
There was a problem hiding this comment.
Doesn't the command above also handle the units?
There was a problem hiding this comment.
Ah yes, I will remove this comment in the next PR
barbalt
approved these changes
Oct 1, 2024
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UI for export units:
Scale during export:
Add unit tests.