EMSUSD-947 units conversion for USD import #3941
Conversation
pierrebai-adsk
commented
Oct 2, 2024
pierrebai-adsk
commented
- Add -unit (-unt) option to the import command.
- Document it.
- Add unit option to the job import argument structure.
- Parse the unit option.
- Expose it to Python.
- Add check-box UI to the import UI.
- Add private structure to the import read job class to hold all conversion info.
- Remove old warning about unit conversion not being implemented.
- Refactor the code for up-axis conversion to also handle the units conversion.
- Change prefs for units if requested and needed.
- Add unit tests.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-947/import-usd-units
branch
from
d5db7ef
to
6321743
Compare
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-947/import-usd-units
branch
from
6321743
to
887c600
Compare
- Add -unit (-unt) option to the import command. - Document it. - Add unit option to the job import argument structure. - Parse the unit option. - Expose it to Python. - Add check-box UI to the import UI. - Add private structure to the import read job class to hold all conversion info. - Remove old warning about unit conversion not being implemented. - Refactor the code for up-axis conversion to also handle the units conversion. - Change prefs for units if requested and needed. - Add unit tests.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-947/import-usd-units
branch
from
887c600
to
4174814
Compare
| @@ -152,6 +152,11 @@ double ConvertMDistanceUnitToUsdGeomLinearUnit(const MDistance::Unit mdistanceUn | |||
| MAYAUSD_CORE_PUBLIC | |||
| MDistance::Unit ConvertUsdGeomLinearUnitToMDistanceUnit(const double linearUnit); | |||
|
|
|||
| /// Convert the given \p mdistanceYnit into its text representation suitable | |||
There was a problem hiding this comment.
Will be fixed in next PR about units and up-axis in USD stages.
pierrebai-adsk
added
the
ready-for-merge
Anything specific? You can log issues in Jira if you think something cold be broken. |
I have some bad experiences when implementing the import/export when converting different units. Scaling was the biggest culprit of bad things happening.. Animations wouldn't translate properly due to mesh have different matrices and so on.. Hence why I mentioned scaling in particular.. I guess we'll see with tests.. |
