Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please fix IfcClassification #546

Closed
louistrue opened this issue Nov 15, 2022 · 23 comments
Closed

Please fix IfcClassification #546

louistrue opened this issue Nov 15, 2022 · 23 comments

Comments

@louistrue
Copy link

I cant get Classification to work anymore, no matter what Version of the exporter I install. Both for Revit 2022 and 2023. There is either no classification exported, for example when I leave the "Classification Code" empty (even though that is supposed to be the default value I have to put in "Classification Code") or the classification gets split up in many parts:

image

image
@AngelVelezSosa
Copy link
Contributor

@WawanSolihin - as far as I know there are no regressions here.

@WawanSolihin
Copy link
Contributor

Not that I know of, but there is also another bug report that is similar. I will take a look as soon as I am available.

@louistrue
Copy link
Author

Thanks, see also:

#543 (comment)
#509 (comment)
#489 (comment)

@louistrue
Copy link
Author

louistrue commented Nov 17, 2022 •
edited
Loading

image

@WawanSolihin Thats whats going wrong, managed to fix it with Notepad++

image

@louistrue
Copy link
Author

Seems like the newest Solibri update fixed this on the Solibri side: #543 (comment)

Still think this should be fixed in the exporter as well...

@HenkMolhoek
Copy link

The latest version of Solibri has changed the Uniformat Classification to Uniformat.
This has already been reported to Solibri.
But this does not solve the problem in IFC

@dvrvb
Copy link

dvrvb commented Nov 18, 2022

Hopefully that was reported as a congratulation to Solibri for that correction and not as bug.

@AngelVelezSosa
Copy link
Contributor

This seems like the same issue as #543 but also I am not sure I see a bug on the exporter side. The name in IfcRelAssociatesClassification should not be relevant to a viewer. I will reopen if someone shows me that I am missing something here.

@louistrue
Copy link
Author

I disagree, @AngelVelezSosa . It is just confusing to have that value there and I think many agree. Just because Solibri fixed an old bug that was probably discovered after the recent changes in the Revit exporter doesn't mean it's fine. Other viewers/applications have similar trouble.

Since "Name" is an optional attribute: why not just leave it empty?

@louistrue louistrue mentioned this issue Nov 18, 2022
Closed
@AngelVelezSosa
Copy link
Contributor

I will check to see if the name has value, and if it doesn't really we can leave it empty. But I am not sure why that value would be confusing or not. This isn't the name of the classification; this is the name of a reference entity that is an implementation detail for how IFC is represented (by making relationships be first-class entities instead of being attributes). It seems odd that an application looks at a value and, if it is set, does the wrong thing with it.

@WillemdBr
Copy link

@AngelVelezSosa @louistrue @dvrvb @HenkMolhoek
We've contacted Solibri about this issue and they've send us their answer:

Hi Willem,

From the link below, you can see the classification name should be taken from IFCCLASSIFICATION

https://standards.buildingsmart.org/IFC/RELEASE/IFC2x3/TC1/HTML/ifcexternalreferenceresource/lexical/ifcclassification.htm

Earlier versions of Solibri derived the classification name from the relation IFCRELASSOCIATESCLASSIFICATION

https://standards.buildingsmart.org/IFC/RELEASE/IFC2x3/TC1/HTML/ifckernel/lexical/ifcrelassociatesclassification.htm

I hope this is clear, it is not a bug in Solibri but a fix for the updated IFC standards.

Thank you.

Best regards,
Solibri Support Team

@HenkMolhoek
Copy link

HenkMolhoek commented Nov 21, 2022 via email

@AngelVelezSosa
Copy link
Contributor

@WillemdBr : Doesn't what Solibri state seem like there is a Solibri bug? It should take the value from IfcClassification, not IfcRelAssociatesClassification?

Regardless, we will look into making a fix for compatibility, but it does seem like a bunch of viewers decided to do something odd.

@WawanSolihin
Copy link
Contributor

@AngelVelezSosa @louistrue @dvrvb @HenkMolhoek We've contacted Solibri about this issue and they've send us their answer:

Hi Willem,

From the link below, you can see the classification name should be taken from IFCCLASSIFICATION

https://standards.buildingsmart.org/IFC/RELEASE/IFC2x3/TC1/HTML/ifcexternalreferenceresource/lexical/ifcclassification.htm

Earlier versions of Solibri derived the classification name from the relation IFCRELASSOCIATESCLASSIFICATION

https://standards.buildingsmart.org/IFC/RELEASE/IFC2x3/TC1/HTML/ifckernel/lexical/ifcrelassociatesclassification.htm

I hope this is clear, it is not a bug in Solibri but a fix for the updated IFC standards.

Thank you.

Best regards, Solibri Support Team

I am not sure what Solibri support team referred to that says the Classification name is taken from ifcrelassociatesclassification in the specification. The schema specifies that the classification name may be specified by IfcClassification, which may be optional (not specified). The name in ifcrelassociatesclassification, as name in the other entities is simply an identification of the entity itself (in this case ifcrelassociatesclassification) and should not be the reference to the Classification itself.
Regardless, I think it is an issue with Solibri

@dvrvb
Copy link

dvrvb commented Nov 21, 2022

Since when the IFC2x3 TC1 can be considered as "updated" IFC standard??? (as far as I know buildingSMART did not do any sneaky updates last month in the official TC1 specification)

@AngelVelezSosa AngelVelezSosa mentioned this issue Nov 21, 2022
Open
@Moult
Copy link

Moult commented Nov 22, 2022

Apologies I'm writing this on a phone on holiday but from what I can tell the name and description on the rel associates classification should not have any impact on the semantics of classification names or reference names.

So yes, Revit is doing things correctly and it is Solibri which needs to fix things (which from what I read in this thread is already fixed?)

@HenkMolhoek
Copy link

Thank you for explaining and clarifying the change.
Will there also be a change to Navisworks because this viewer does not read the IFC properly.
Here too we are the same result as what Solibri 9.12 showed.

@AngelVelezSosa
Copy link
Contributor

I'll check to see why Navis has an issue here.

@HenkMolhoek
Copy link

The problem arises when Conversion Method Legacy (v1) is activated. We use this method.
Conversion Method V2 and V3 are going well.
Knipsel

@AngelVelezSosa
Copy link
Contributor

Then it seems as if it has already been resolved in Navis and isn't a problem in BIM360.

@HenkMolhoek
Copy link

It is fixed in BIM360 and in navisworks but not in Navisworks Conversion Method Legacy (v1) .
V1 is the fastest and most reliable method to convert IFC. we are using Navisworks Manage 2022 Update 3
or Navisworks Manage 2023 Update 1

can you look at this?
2022-11-23_13-54-50

@AngelVelezSosa
Copy link
Contributor

v1 is likely the fastest but was replaced by v2 and then v3 because they are overall more reliable (and actively maintained, whereas v1 is legacy.) Note that v3 is strictly faster than v2, so there is little (or hopefully no) reason to use it vs. v3. All active work is going towards improving the performance and reliability of v2/v3.

@AngelVelezSosa AngelVelezSosa mentioned this issue Dec 2, 2022
Open
@HenkMolhoek
Copy link

is there an update yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Moult @AngelVelezSosa @WawanSolihin @WillemdBr @dvrvb @HenkMolhoek @louistrue