ReferenceIFC added Out reference to get the ElementId #423
Conversation
…ted IFC to manipulate it later
| @@ -439,8 +439,10 @@ private bool DocumentUpToDate(Document doc, string ifcFileName) | |||
| /// <param name="document">The host document for the import.</param> | |||
| /// <param name="origFullFileName">The full file name of the document.</param> | |||
| /// <param name="options">The list of configurable options for this import.</param> | |||
| public void ReferenceIFC(Document document, string origFullFileName, IDictionary<String, String> options) | |||
| public void ReferenceIFC(Document document, string origFullFileName, IDictionary<String, String> options, out ElementId revitLinkTypeId) | |||
| { | |||
There was a problem hiding this comment.
Would it be better to just return the ElementId instead?
There was a problem hiding this comment.
that was my first idea, but I've thought that changing the return method from void to ElementId could it be potentially more distruptive for existing codes which uses this DLL rather than leaving to void and using an out reference
There was a problem hiding this comment.
Hmm, I guess it depends if it is overridden or not. I would think changing void to ElementId as a return wouldn't be so bad, would it? Vs. changing the signature?
There was a problem hiding this comment.
well, returning ElementId it would be cleaner and more straightforward too, if you think that's ok for compatibility I'd also prefer that way,
do you want me to create another pull request with the implementation?
while I was building an automation to link IFCs into a file, I found it useful to add an out reference to the method in order to catch the ElementId of the newly imported document and manipulate it afterward