Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dkirillov/gh-76: Diff command - LoadConfig arg fix #77

Merged
merged 1 commit into from
May 11, 2023
Merged

dkirillov/gh-76: Diff command - LoadConfig arg fix #77

merged 1 commit into from
May 11, 2023

Conversation

dkirillov
Copy link
Collaborator

Overview

Github Issue: #76

Summary (required always)

This PR fixes diff command's use of LoadConfig by providing the arguments in proper order.

Notes

Built and tested locally:

screenshots

Screenshot 2023-05-04 at 12 47 59 PM
Screenshot 2023-05-04 at 1 04 28 PM
Screenshot 2023-05-04 at 1 06 42 PM

Unit tests pass:

screenshot

Screenshot 2023-05-04 at 1 11 09 PM

Checklist

  • My pull request title follows the format <username>/<gh-issue-#number>:<short-description>
  • My code passes existing unit tests
  • My code follows the code style set for the project
  • I have added at least one reviewer for this PR

@dkirillov dkirillov requested a review from a team as a code owner May 4, 2023 17:11
@dkirillov dkirillov added the bug Something isn't working label May 4, 2023
slonokot
slonokot approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@slonokot slonokot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO: worth adding integration tests for diff - we don't have them.

@dkirillov dkirillov mentioned this pull request May 11, 2023
Open
@dkirillov
Copy link
Collaborator Author

IMO: worth adding integration tests for diff - we don't have them.

Agreed - created #78 . Though, I believe diff's functionality should be restored first to allow others to use it.

@dkirillov dkirillov merged commit 3b9b13c into main May 11, 2023
@dkirillov dkirillov deleted the dkirillov/gh-76-diff-fix branch May 11, 2023 14:09
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@slonokot slonokot slonokot approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkirillov @slonokot