Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when using option "Sample keyframes only", grab all frames with either IK or FK keyframes #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

when using option "Sample keyframes only", grab all frames with either IK or FK keyframes #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd93ec7
when using Sample Keyframe Only option, export ANY frame that has eit…
aatb-ch Nov 16, 2023
c2b93f7
properly sort and dedup final list
aatb-ch Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 43 additions & 8 deletions mimic3/scripts/mimic_program.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
try:
import pymel.core as pm
import maya.mel as mel
import numpy as np

MAYA_IS_RUNNING = True
except ImportError: # Maya is not running
Expand Down Expand Up @@ -937,29 +938,63 @@ def _get_frames_using_sample_rate(animation_settings, postproc_settings):
def _get_frames_using_keyframes_only(robot, animation_settings):
"""
Get frames from animation using a robot's keyframes only.
This will include ANY keyframe set on either IK tool_CTRL or any of the 6 FK_CTRL handles.
:param robot:
:param animation_settings:
:return:
"""
# Get relevant animation parameters.
start_frame = animation_settings['Start Frame']
end_frame = animation_settings['End Frame']

# Get list of keyframes on robots IK attribute for the given range
target_ctrl_path = mimic_utils.get_target_ctrl_path(robot)
ik_keyframes = pm.keyframe(
target_ctrl_path,
attribute='ik',
query=True,
time='{}:{}'.format(start_frame, end_frame))
# Verify that there is also a keyframe set on the FK controls' rotate
# attributes. If there's not, we remove it from the list
# Note: we only need to check one controller as they are all keyframed
# together
fk_test_handle_path = mimic_utils.format_path('{0}|{1}robot_GRP|{1}FK_CTRLS|{1}a1FK_CTRL.rotateY', robot)
frames = [frame for frame in ik_keyframes if pm.keyframe(
fk_test_handle_path,

# Get all FK keyframes set per each individual joints
fk_1_path = mimic_utils.format_path('{0}|{1}robot_GRP|{1}FK_CTRLS|{1}a1FK_CTRL.rotateY', robot)
fk_1_keyframes = pm.keyframe(
fk_1_path,
query=True,
time='{}:{}'.format(start_frame, end_frame))

fk_2_path = mimic_utils.format_path('{0}|{1}robot_GRP|{1}FK_CTRLS|{1}a2FK_CTRL.rotateX', robot)
fk_2_keyframes = pm.keyframe(
fk_2_path,
query=True,
time='{}:{}'.format(start_frame, end_frame))

fk_3_path = mimic_utils.format_path('{0}|{1}robot_GRP|{1}FK_CTRLS|{1}a3FK_CTRL.rotateX', robot)
fk_3_keyframes = pm.keyframe(
fk_3_path,
query=True,
time='{}:{}'.format(start_frame, end_frame))

fk_4_path = mimic_utils.format_path('{0}|{1}robot_GRP|{1}FK_CTRLS|{1}a4FK_CTRL.rotateY', robot)
fk_4_keyframes = pm.keyframe(
fk_4_path,
query=True,
time='{}:{}'.format(start_frame, end_frame))

fk_5_path = mimic_utils.format_path('{0}|{1}robot_GRP|{1}FK_CTRLS|{1}a5FK_CTRL.rotateX', robot)
fk_5_keyframes = pm.keyframe(
fk_5_path,
query=True,
time='{}:{}'.format(start_frame, end_frame))

fk_6_path = mimic_utils.format_path('{0}|{1}robot_GRP|{1}FK_CTRLS|{1}a6FK_CTRL.rotateZ', robot)
fk_6_keyframes = pm.keyframe(
fk_6_path,
query=True,
time=frame)]
time='{}:{}'.format(start_frame, end_frame))

# combine all keyframe lists as one unique and deduplicated list
frames = list(np.unique(ik_keyframes + fk_1_keyframes + fk_2_keyframes + fk_3_keyframes + fk_4_keyframes + fk_5_keyframes + fk_6_keyframes))

return frames


Expand Down