Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README files with local dev environment setup #729

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

hanifn
Copy link

@hanifn hanifn commented Jun 4, 2024

Description

This PR updates the README files with instructions on how to set up a local development environment using wp-env.

Steps to Test

N/A

@hanifn hanifn self-assigned this Jun 4, 2024
@hanifn hanifn requested a review from ingeniumed June 4, 2024 07:50
Copy link
Contributor

@ingeniumed ingeniumed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make this change in your PR as well? Essentially, you'd need to:

  • Change GPL2+ to GPL3+ in composer.json
  • Add a LICENSE file at the root of the repo which is the GPL3 license

Also, I'll change your branch base to develop as we merge our changes in there first before cutting a release for master.


= 0.1.5 =
* Ability to assign custom statuses to posts
=== Edit Flow ===
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this happen as well, and the way I avoided the entire file changing was by doing cmd+k followed by s in vscode. That way it didn't format this file. Prob worth adding it to the prettierignore maybe

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried reverting the changes and doing what you suggested but git is saying there are no changes to commit 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thoughts, lets leave it so we don't need to keep doing this revert. Better to get it done in one go

@hanifn
Copy link
Author

hanifn commented Jun 6, 2024

Could you make #727 (comment) change in your PR as well?

@ingeniumed Updated the license in 22551d3

@hanifn hanifn changed the base branch from master to develop June 6, 2024 06:55
@hanifn
Copy link
Author

hanifn commented Jun 6, 2024

Also, I'll change your branch base to develop as we merge our changes in there first before cutting a release for master.

@ingeniumed I've changed the target branch as well

@ingeniumed ingeniumed merged commit b7d70af into develop Jun 6, 2024
3 checks passed
@ingeniumed ingeniumed deleted the update/readme branch June 6, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants