-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the block editor JS/CSS blocks for the custom status #731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Custom status is still working as expected.
Just have a non-blocking suggestion to your duplicated code question
I have re-enabled the php cs diff test but I haven't fixed them in this PR because it's over 2000 lines of changes. I'll follow up with another PR that focuses on that, so it's easy to revert any build problems in the JS vs the php side. |
Description
This will make the block editor version of the custom status module the default one. It uses the newer actions to load it, in just the block editor. In addition, it also moves the files to the module and loads everything that's compiled in the generic dist folder. The intention is that once we convert everything away from JQuery, it can just sit in that dist folder.
I've also disabled the PHPCSDiff script just in the interest of making it easier for us to update each of the modules. We can re-enable this later, once we have re-done each of the modules.
Steps to Test