Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing back old image upload method #493

Open
wants to merge 2 commits into
base: andrewdmontgomery/support-setting-uploaded-image-as-avatar
Choose a base branch
from

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Oct 11, 2024

Closes #

Description

This PR continues the work on #492 and targets it.

  • Bringing back old good upload(_:email: accessToken:) -> URLResponse, which uses the v1 upload endpoint
  • Removing avatarSelection from the v3 image upload method.
  • AvatarSelection is now internal.

upload(_:email: accessToken:) -> URLResponse
and
upload(_:accessToken:) -> AvatarType
use the v1 and v3 endpoints respectively.

Testing Steps

@wpmobilebot
Copy link

Gravatar UIKit Prototype Build📲 You can test the changes from this Pull Request in Gravatar UIKit Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar UIKit Prototype Build Gravatar UIKit Prototype Build
Build Number1479
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-uikit.prototype-build
Commit4aab077
App Center BuildGravatar SDK Demo - UIKit #257
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link

Gravatar SwiftUI Prototype Build📲 You can test the changes from this Pull Request in Gravatar SwiftUI Prototype Build by scanning the QR code below to install the corresponding build.
App NameGravatar SwiftUI Prototype Build Gravatar SwiftUI Prototype Build
Build Number1479
Version1.0
Bundle IDcom.automattic.gravatar-sdk-demo-swiftui.prototype-build
Commit4aab077
App Center BuildGravatar SDK Demo - SwiftUI #257
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants