Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Description
This fixes a bug i detected during the Jetpack integration. Because of the way we initialize the
@State
variable, the token was not being set successfully. This article does a good job explaining why: https://www.swiftcraft.io/articles/how-to-initialize-state-inside-the-views-init-So I am separating the local
@State
token from the one passed from outside.Also removing the
@State
from scope as well, it doesn't need to be a@State
. This is not directly related with the bug but it's a wrong usage as well so needs fixing.I also rearranged the lines a bit.
Testing Steps
Go to UIKit Demo app > QE
Enter
email
Enter
token
<-- importantTap Logout if the button is present
Open the QE, verify it does NOT go through OAuth and goes directly to QE.